Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108264
MIME-Version: 1.0
References: <CAG9XoMTUCYdZyGXDR+gVEQDcnfL_z_XNiZ=ztwybSN0jVNG2Sg@mail.gmail.com>
In-Reply-To: <CAG9XoMTUCYdZyGXDR+gVEQDcnfL_z_XNiZ=ztwybSN0jVNG2Sg@mail.gmail.com>
Date: Mon, 27 Jan 2020 10:51:31 +0100
Message-ID: <CAF+90c-NmehfOjhR4hsSd0d-owgtzPEkY1na6dNgg2G613r90Q@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003b5ab0059d1c0e3c"
Subject: Re: [PHP-DEV] WeakMap vs PECL WeakMap
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000003b5ab0059d1c0e3c
Content-Type: text/plain; charset="UTF-8"

On Mon, Jan 20, 2020 at 2:58 PM Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> Hi Internals,
>
> A year ago, when WeakRef was being proposed, some objections
> <https://externals.io/message/104014#104068> related to the PECL Weakref
> package <https://www.php.net/manual/fr/book.weakref.php> had lead the RFC
> author, Joe Watkins, to rename WeakRef to WeakReference to avoid conflicts.
>
> However, the latest addition from Nikita Popov, WeakMap
> <https://wiki.php.net/rfc/weak_maps>, did not take the same argument into
> account, therefore conflicting with PECL WeakMap
> <https://www.php.net/manual/fr/class.weakmap.php>.
>
> *First of all, how will this be handled in the docs?*
>
> Now that we have a conflict on WeakMap anyway, and now that the PECL
> package has been deprecated, and provided that the conflict can be
> gracefully handled in the docs, *is there anything that prevents
> WeakReference from being called WeakRef?*
>
> Could we have both names in PHP 8, like WeakReference being an alias for
> WeakRef?
>

I don't see a point in renaming the class now that the WeakReference name
has been chosen. I don't agree with the reasons *why* it was picked, but
it's not like "WeakReference" is a bad name in itself. That's what Java
calls it as well, for example.

Regards,
Nikita

--0000000000003b5ab0059d1c0e3c--