Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108212
MIME-Version: 1.0
References: <CAFPFaM+jztyaVeZ8WWa5WabkA7N1pf+D3-dhbAykgQQ14M07TQ@mail.gmail.com>
 <0c59dbea-2df6-d13d-e6f2-79495b6c1603@telia.com> <CAF+90c_8x66nsNmJbG4FbZzf1o1Cr0Jj4CmNvkUwuZ7dk1WCUQ@mail.gmail.com>
 <CAGKNXQHLZCyRDp9-nwzxdts4J+mqjUN+-qfdo8K2cVLNU5NNsA@mail.gmail.com> <CAAwbVud00uMVvPJfLT5PUTtJrfnESQKYq3qQr67TQjh7_t4Dkg@mail.gmail.com>
In-Reply-To: <CAAwbVud00uMVvPJfLT5PUTtJrfnESQKYq3qQr67TQjh7_t4Dkg@mail.gmail.com>
Date: Tue, 21 Jan 2020 23:52:17 +0100
Message-ID: <CAF+90c9ALgrtqmYP1eiszxYbB89MEz1ikySntBkZC+0vfH_DUg@mail.gmail.com>
To: Olumide Samson <oludonsexy@gmail.com>
Cc: Philip Hofstetter <phofstetter@sensational.ch>, 
	=?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, 
	George Peter Banyard <girgias@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007afe7f059cae4395"
Subject: Re: [PHP-DEV] Adding TypeError and ValueError to count() function
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000007afe7f059cae4395
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 21, 2020 at 9:51 PM Olumide Samson <oludonsexy@gmail.com> wrote=
:

> Only lazy developers would complain about updating legacy code, perhaps
> the code itself is worthless and need not be updated.
>
> Then, what's the point of pursuing latest features or PHP version when a
> individual or a company can't pursue code upgrade before version update?
>

Please don't be rude.

Nikita

On Tue, Jan 21, 2020, 8:41 PM Philip Hofstetter <phofstetter@sensational.ch=
>
> wrote:
>
>> Hi,
>>
>>
>> On Tue, Jan 21, 2020 at 6:17 PM Nikita Popov <nikita.ppv@gmail.com>
>> wrote:
>>
>> >
>> > In the cases you encountered, do you know what type count() was used o=
n?
>> > Was it null? false? Or something else?
>> >
>> > Nikita
>>
>> we were in a similar boat as Bj=C3=B6rn to the point where we manually
>> patched PHP in production in order to not emit that warning so we
>> could update PHP while we were migrating the code-base. This made the
>> 7.1 to 7.2 update the most painful update in the history of this
>> application (which was first released when 5.0.0 came out).
>>
>> The most common case was `count(null)` which unfortunately was
>> happening all the time because of functions deciding to return an
>> array with elements or null if there was no elements to be found. Yes,
>> that's bad form, but hey - this is a nearly 20 years old application.
>>
>> Of all the changes I've seen happening in PHP, this was the most painful=
.
>>
>> Philip
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>

--0000000000007afe7f059cae4395--