Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108207
MIME-Version: 1.0
References: <CAFPFaM+jztyaVeZ8WWa5WabkA7N1pf+D3-dhbAykgQQ14M07TQ@mail.gmail.com>
 <0c59dbea-2df6-d13d-e6f2-79495b6c1603@telia.com> <CAF+90c_8x66nsNmJbG4FbZzf1o1Cr0Jj4CmNvkUwuZ7dk1WCUQ@mail.gmail.com>
In-Reply-To: <CAF+90c_8x66nsNmJbG4FbZzf1o1Cr0Jj4CmNvkUwuZ7dk1WCUQ@mail.gmail.com>
Date: Tue, 21 Jan 2020 20:40:34 +0100
Message-ID: <CAGKNXQHLZCyRDp9-nwzxdts4J+mqjUN+-qfdo8K2cVLNU5NNsA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, 
	George Peter Banyard <girgias@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Adding TypeError and ValueError to count() function
From: phofstetter@sensational.ch (Philip Hofstetter)

Hi,


On Tue, Jan 21, 2020 at 6:17 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

>
> In the cases you encountered, do you know what type count() was used on?
> Was it null? false? Or something else?
>
> Nikita

we were in a similar boat as Bj=C3=B6rn to the point where we manually
patched PHP in production in order to not emit that warning so we
could update PHP while we were migrating the code-base. This made the
7.1 to 7.2 update the most painful update in the history of this
application (which was first released when 5.0.0 came out).

The most common case was `count(null)` which unfortunately was
happening all the time because of functions deciding to return an
array with elements or null if there was no elements to be found. Yes,
that's bad form, but hey - this is a nearly 20 years old application.

Of all the changes I've seen happening in PHP, this was the most painful.

Philip