Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108184
MIME-Version: 1.0
References: <CAF+90c-YHBKfMG1foO6HZWeyD5h2WnQFN5fmXG9V2sZ_uFRW-A@mail.gmail.com>
 <AM6PR09MB33179863985F88717A71D562E2390@AM6PR09MB3317.eurprd09.prod.outlook.com>
 <CAF+90c9CJFtTp-TbkLVrBRfa96m_+YzHVNs1byibS+YBK4MJxQ@mail.gmail.com> <CANUQDChLphpeh2Sn03Xk+E7bWeP6mdqSBXD-tkBkqmnTw4ybGA@mail.gmail.com>
In-Reply-To: <CANUQDChLphpeh2Sn03Xk+E7bWeP6mdqSBXD-tkBkqmnTw4ybGA@mail.gmail.com>
Date: Fri, 17 Jan 2020 18:59:42 +0100
Message-ID: <CAF+90c-8O1RJ2Em2Qac3Bnda7BeeVmZi66moVMi5CRf56Yom7Q@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: Bob Weinand <bobwei9@hotmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b59242059c59b551"
Subject: Re: [PHP-DEV] Warn when declaring required parameter after optional one
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000b59242059c59b551
Content-Type: text/plain; charset="UTF-8"

On Sat, Jan 11, 2020 at 2:35 PM Niklas Keller <me@kelunik.com> wrote:

> Hi Nikita,
>
> while this is a rather small change, it has quite some BC impact, as
> not all old code has been adjusted to run on PHP 7.1+ only using
> nullable types.
>
> I'd like to see an RFC with a vote for this.
>
> Regards,
> Niklas
>

I was interested in seeing how prevalent this pattern, is, so I ran some
analysis on the top 2k composer packages. I found 527 signatures that would
throw a deprecation warning with this change. Of these 187 are potentially
used as "poor man's nullable types" (the optional argument has both a type
and a null default), while the other 340 are definite bugs.

Regards,
Nikita

--000000000000b59242059c59b551--