Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108066
DomainKey-Signature: a=rsa-sha1; c=nofws; d=noctuint.cz; h=from:to:cc
	:references:in-reply-to:subject:date:message-id:mime-version
	:content-type:content-transfer-encoding; q=dns; s=mail; b=LMmDI2
	Ok/3TIOGaAku14Vsdv/38Noe/kQVqnxFrQOhRXe39b/wso/ruXvMZgj81IOx+drv
	k0xXmv7ChR/X0W0/5iiYJ9cCWiJsFiRkFftilUaVWQUsKwH4J4C5FkFgS/eCByGK
	uHyc1ySBhtsj4zq0WWsLV3pS0xLx0Z1nc9oQc=
Reply-To: <mdolezal@noctuint.cz>
To: "'Nikita Popov'" <nikita.ppv@gmail.com>
Cc: "'PHP internals'" <internals@lists.php.net>
References: <003401d5c634$3b617760$b2246620$@noctuint.cz> <CAF+90c_0RvezzTocaNzR-QgvykcOj1m5hKmpAo1Mj-BR97ck1Q@mail.gmail.com> <004b01d5c636$e36f1820$aa4d4860$@noctuint.cz> <CAF+90c-WPpuNesTtwu2L74bj8tUATcPmRs0hfQ6qBN3y+tuhxQ@mail.gmail.com>
In-Reply-To: <CAF+90c-WPpuNesTtwu2L74bj8tUATcPmRs0hfQ6qBN3y+tuhxQ@mail.gmail.com>
Date: Thu, 9 Jan 2020 16:28:12 +0100
Message-ID: <008d01d5c701$69bd8360$3d388a20$@noctuint.cz>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIm0QP2lWPEtE74Z2zXpcTPc0o8WgKNlciDAY0CtugBpTvF86cSYLAQ
Content-Language: cs
Subject: RE: [PHP-DEV] zend_call_method with arguments passed by reference
From: internals@lists.php.net ("mdolezal.noctuint.cz via internals")

Thanks a lot Nikita,
that=E2=80=99s it. I was not aware of no_separation influence, it was =
set to 1 in zend_call_method both in PHP5 and PHP7 so I didn't touch it =
during migration. I need to copy the arguments properly back now but =
basically it's working. Thanks again,
Martin
=20

-----Original Message-----
From: Nikita Popov <nikita.ppv@gmail.com>=20
Sent: Thursday, January 9, 2020 1:17 PM
To: mdolezal@noctuint.cz
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] zend_call_method with arguments passed by =
reference

On Wed, Jan 8, 2020 at 4:18 PM <mdolezal@noctuint.cz> wrote:

> Thank you for your answer Nikita.
> Can you please give me more details what you mean? I can try that =
approach.
> zend_call_method copies the args to params array which is assigned to=20
> zend_fcall_info fci.
> I can pass there for example "test" zval string.
> Then the mentioned lower level zend_call_function() is called with fci =

> as parameter, that's what I do.
> In PHP code "test" is changed to "changed".
> But after the call the fci.params are not changed, still "test", so I=20
> have nothing to copy back manually.
>

fci.params *should* contain the changed parameters after the call, at =
least assuming no_separation=3D0. It's not clear to me under what =
circumstances that wouldn't work.

Nikita


> -----Original Message-----
> From: Nikita Popov <nikita.ppv@gmail.com>
> Sent: Wednesday, January 8, 2020 4:06 PM
> To: mdolezal@noctuint.cz
> Cc: PHP internals <internals@lists.php.net>
> Subject: Re: [PHP-DEV] zend_call_method with arguments passed by=20
> reference
>
> On Wed, Jan 8, 2020 at 3:59 PM mdolezal.noctuint.cz via internals <=20
> internals@lists.php.net> wrote:
>
> > Hello,
> >
> > I hope this is the appropriate mailing list, please redirect me to=20
> > better please if required.
> >
> >
> >
> > I am currently rewriting our PHP extension from PHP5 to PHP7.
> >
> > To call PHP methods from our C/C++ code we use slightly modified=20
> > zend_call_method from Zend/zend_interfaces.c (to use more arguments=20
> > than 2).
> >
> >
> > Now I found out that it does not work with arguments passed by=20
> > reference, such as:
> >
> > public function FuncWithRef(array &$changeThis)
> >
> >
> >
> > if values are changed in the PHP code then zval values back in C=20
> > part after zend_call_function call are not influenced.
> >
> > With PHP5 the value was overwritten and could be used later in C =
code.
> >
> > Previously the zend_fcall_info struct for function call was filled=20
> > with params simply by
> >
> >
> >
> > params[0] =3D &arg1;
> >
> >
> >
> > In PHP7 this is changed to
> >
> >
> >
> > ZVAL_COPY_VALUE(&params[0], arg1);
> >
> >
> >
> > After function is executed (zend_call_function) both fci.params and
> > arg1 contain still the original zval values,
> >
> > changes made in PHP code are not available. Is there any way how to=20
> > solve this?
> >
> > I am mainly searching for and comparing code snippets in PHP/ext=20
> > folder to see how things were rewritten from PHP5 to PHP7.
> >
> > Sorry if I missed something obvious and thank you for your help.
> >
>
> It looks like the implementation of zend_call_method() does not=20
> support this, as it does not copy parameters back after the call. I'd=20
> suggest to use the lower level zend_call_function() for the cases=20
> where you need this for now.
>
> Nikita
>
>
>
>