Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108063
MIME-Version: 1.0
References: <CAF+90c-YHBKfMG1foO6HZWeyD5h2WnQFN5fmXG9V2sZ_uFRW-A@mail.gmail.com>
 <AM6PR09MB33179863985F88717A71D562E2390@AM6PR09MB3317.eurprd09.prod.outlook.com>
In-Reply-To: <AM6PR09MB33179863985F88717A71D562E2390@AM6PR09MB3317.eurprd09.prod.outlook.com>
Date: Thu, 9 Jan 2020 15:46:01 +0100
Message-ID: <CAF+90c9CJFtTp-TbkLVrBRfa96m_+YzHVNs1byibS+YBK4MJxQ@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000057ca1a059bb61293"
Subject: Re: [PHP-DEV] Warn when declaring required parameter after optional one
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000057ca1a059bb61293
Content-Type: text/plain; charset="UTF-8"

On Thu, Jan 9, 2020 at 2:41 PM Bob Weinand <bobwei9@hotmail.com> wrote:

> Hey,
>
> While I generally agree that it likely is a bug in new code, I would
> rather deprecate it than warn or even error: the change would make it
> impossible to retain a type without warning while preserving compatibility
> with an old PHP version and making incremental migrations harder (would
> then not be possible to write warning-free code running on 7.0 and 8.0 at
> the same time while retaining type information).
>
> I would like to see it deprecated and then removed in 4+ years.


> Bob
>

As deprecation and later removal seem to be preferred by multiple people,
I've changed the PR to implementation that instead.

Nikita


> > Am 09.01.2020 um 13:27 schrieb Nikita Popov <nikita.ppv@gmail.com>:
> >
> > Hi internals,
> >
> > I've created https://github.com/php/php-src/pull/5067 to make code like
> >
> >    function test($foo = null, $bar) {}
> >
> > throw a warning:
> >
> >    Warning: Required parameter $bar follows optional parameter
> >
> > Historically, having an "optional" parameter before a required one was
> > useful for poor man's nullable types. That is, one could write
> >
> >    function test(FooBar $param = null, $param2)
> >
> > to get an effective
> >
> >    function test(?FooBar $param, $param2)
> >
> > signature on old PHP versions that did not have native support for
> nullable
> > types.
> >
> > Since nullable types have been available since PHP 7.1, having a required
> > parameter after an optional one is increasingly likely a bug rather than
> an
> > intentional workaround, so I think it would be good to throw a warning
> for
> > this case.
> >
> > What do you think?
> >
> > Nikita
>

--00000000000057ca1a059bb61293--