Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108062
MIME-Version: 1.0
References: <CAF+90c-vPOmHzjoDFNi3m+iTgfz6dJep1DAHuCFcQDctjeEJMg@mail.gmail.com>
 <e30686d8-4836-4403-851f-06f296ccbafd@www.fastmail.com> <CAH0Uv3Hp2GUwKX0YOs-E1-1W9LkXzc71pBsvNQRnRvNicw=YdQ@mail.gmail.com>
 <CAH0Uv3HLpO0ov=2pPG3fQcbXXCQBRmp6uh+2=pd9OFeYhf-oew@mail.gmail.com>
In-Reply-To: <CAH0Uv3HLpO0ov=2pPG3fQcbXXCQBRmp6uh+2=pd9OFeYhf-oew@mail.gmail.com>
Date: Thu, 9 Jan 2020 15:40:54 +0100
Message-ID: <CAOWwgpkiUFaBHK1ycVicVdbz7fkFTZCqx0C4hx=z9U+L5fyc1Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: php internals <internals@lists.php.net>, Andreas Hennings <andreas@dqxtech.net>
Content-Type: multipart/alternative; boundary="000000000000cfad04059bb5ffd8"
Subject: Re: [PHP-DEV] [RFC] Static return type
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000cfad04059bb5ffd8
Content-Type: text/plain; charset="UTF-8"

> Of course this ": $this" could be added later in the future.
> But this would have the risk that people start adding ": static" on methods
> that really return $this.
>

I second $this. I also would like to be able to declare `function foo():
$this` at the same time as `function foo(): static` so that we can use the
most accurate description right away.

Although I'm not into the C part of the proposal, if I may have a
suggestion here, it would be to implement the check *at compile time*. Like
nullable return types check at compile time that `return null;` is used
instead of just `return;`, I think a `$this` return type could and should
enforce `return $this;` on all return point of such methods. That would
also make the check free at runtime.

Cheers,
Nicolas

--000000000000cfad04059bb5ffd8--