Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:108057 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 65442 invoked from network); 9 Jan 2020 16:12:29 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 9 Jan 2020 16:12:29 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 44835180533 for ; Thu, 9 Jan 2020 06:18:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 9 Jan 2020 06:18:09 -0800 (PST) Received: by mail-io1-f53.google.com with SMTP id h8so7286976iob.2 for ; Thu, 09 Jan 2020 06:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iNeiphXrIXrIlVCcr/xNqBGov0NZO2uW3W89D/KR6Ro=; b=PS9tNZSLeHNKSSXOMso98+gwsVdSkiP/xWhOAc++Nuz1DyXhdJmTAueVfSdAErMhQc ziiXcwlN2lNxBFQlSIqOV4niJ2x7L+sAqAz8ayqKm9bzM+g6LT1oZiTRnB9swCqkLW/A lnZniIiNfNsbdqtUkMTo/3+rroC3f3vcGpED8k0vBiwWsPf2x46xbGspVpOEtVpxmuxr DCzXj+69Q0mAVFLpozKdfvbh5nm5+a88reZ9nzY8LsCHXw8cK117dnfj0A+OFdTtXWmv fFZcFIMEStb0MyF03EcBRqOKkLayiDUR/lKLtr1xLUuVfRYMA3gn5deMfb11Qmb4x38m YknQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iNeiphXrIXrIlVCcr/xNqBGov0NZO2uW3W89D/KR6Ro=; b=iKaE0viRDsFb+2wYJ5FWXw6eAVjW/si3QjIYP9BjmcbCVRuBuGsh0COijJADDAVx3q eTNGFtNiqfuSL23YiceeKjLtALZOS8TKb03tCeEaa3yhfyvBdd2cidhy8OkhKQHtN7LE dopafEZ2jirjVrNg7MOwASQHzA4wk7OH0ItLqmKLmA7fpABmqfWhNYHEMD02aDllUJsE 8jrU7dbL8roctuebDgXY52fVtfvE80cPKi1HbcNLcO9zCVSEfl4uwwfU9FyEbDxu7Euz B0CBkddAkzDMBuWSEx7afcTC42rT1+/B3qqfMioTWTg8RNGoXq5pcGhhdkt7aNNP9qp9 lnvg== X-Gm-Message-State: APjAAAXngn7LDCUAqdT4MxqLN163toFobV7/ArsF+nj58tTJlMx1Qvgz uA7nRek1R5oJvMnSl458qBVRsYY/QMY8bMb1rcN1XS2bmx4= X-Google-Smtp-Source: APXvYqzB0P7TMq3wIv6Zw+1m/Xphmaf/wN8s+VZxMcHvyuXCqqw7m3mcuNLhUpeUPzgd0E99ue0fzNRhktVZE+J92ds= X-Received: by 2002:a5d:8055:: with SMTP id b21mr7826788ior.169.1578579486957; Thu, 09 Jan 2020 06:18:06 -0800 (PST) MIME-Version: 1.0 References: <3b392441-9987-ef36-195e-214bbb50406f@php.net> <5e173351.1c69fb81.540a4.58c3SMTPIN_ADDED_MISSING@mx.google.com> In-Reply-To: <5e173351.1c69fb81.540a4.58c3SMTPIN_ADDED_MISSING@mx.google.com> Date: Thu, 9 Jan 2020 15:17:56 +0100 Message-ID: To: Mark Randall Cc: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Warn when declaring required parameter after optionalone From: gertp93@gmail.com (Gert) > I could understand a warning or deprecation in a minor release, but as there's already so many engine level exceptions landing in 8.0, I think it makes sense to throw this on the pile as well to be swept up in the same pass of migrations that people do in preperation for 8.0. If this would've generated a warning in 7.4 then making this a compile time error is acceptable. But going from nothing to an error without any kind of warning makes the upgrade harder than it needs to be. I think this should be a warning, and then an exception in 9.0. Unless there is gonna be a PHP 7.5 where only deprecations get added, in that case an error in 8.0 would be fine. -- Gert On Thu, 9 Jan 2020 at 15:06, Mark Randall wrote: > > On 09/01/2020 12:31, Sebastian Bergmann wrote: > > I would prefer erroring out over just emitting a warning. > > I'm in agreement with Sebastian, a compile time error is the way to go. > > I could understand a warning or deprecation in a minor release, but as > there's already so many engine level exceptions landing in 8.0, I think > it makes sense to throw this on the pile as well to be swept up in the > same pass of migrations that people do in preperation for 8.0. > > Better to get the pain over and done with, rather than drag it out over > multiple versions, as I'd guess that even if it was a warning now, it > would end up a compile error a few years from now. > > -- > Mark Randall > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >