Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108051
MIME-Version: 1.0
References: <003401d5c634$3b617760$b2246620$@noctuint.cz> <CAF+90c_0RvezzTocaNzR-QgvykcOj1m5hKmpAo1Mj-BR97ck1Q@mail.gmail.com>
 <004b01d5c636$e36f1820$aa4d4860$@noctuint.cz>
In-Reply-To: <004b01d5c636$e36f1820$aa4d4860$@noctuint.cz>
Date: Thu, 9 Jan 2020 13:16:40 +0100
Message-ID: <CAF+90c-WPpuNesTtwu2L74bj8tUATcPmRs0hfQ6qBN3y+tuhxQ@mail.gmail.com>
To: mdolezal@noctuint.cz
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000033aff7059bb3fc6d"
Subject: Re: [PHP-DEV] zend_call_method with arguments passed by reference
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000033aff7059bb3fc6d
Content-Type: text/plain; charset="UTF-8"

On Wed, Jan 8, 2020 at 4:18 PM <mdolezal@noctuint.cz> wrote:

> Thank you for your answer Nikita.
> Can you please give me more details what you mean? I can try that approach.
> zend_call_method copies the args to params array which is assigned to
> zend_fcall_info fci.
> I can pass there for example "test" zval string.
> Then the mentioned lower level zend_call_function() is called with fci as
> parameter, that's what I do.
> In PHP code "test" is changed to "changed".
> But after the call the fci.params are not changed, still "test", so I have
> nothing to copy back manually.
>

fci.params *should* contain the changed parameters after the call, at least
assuming no_separation=0. It's not clear to me under what circumstances
that wouldn't work.

Nikita


> -----Original Message-----
> From: Nikita Popov <nikita.ppv@gmail.com>
> Sent: Wednesday, January 8, 2020 4:06 PM
> To: mdolezal@noctuint.cz
> Cc: PHP internals <internals@lists.php.net>
> Subject: Re: [PHP-DEV] zend_call_method with arguments passed by reference
>
> On Wed, Jan 8, 2020 at 3:59 PM mdolezal.noctuint.cz via internals <
> internals@lists.php.net> wrote:
>
> > Hello,
> >
> > I hope this is the appropriate mailing list, please redirect me to
> > better please if required.
> >
> >
> >
> > I am currently rewriting our PHP extension from PHP5 to PHP7.
> >
> > To call PHP methods from our C/C++ code we use slightly modified
> > zend_call_method from Zend/zend_interfaces.c (to use more arguments
> > than 2).
> >
> >
> > Now I found out that it does not work with arguments passed by
> > reference, such as:
> >
> > public function FuncWithRef(array &$changeThis)
> >
> >
> >
> > if values are changed in the PHP code then zval values back in C part
> > after zend_call_function call are not influenced.
> >
> > With PHP5 the value was overwritten and could be used later in C code.
> >
> > Previously the zend_fcall_info struct for function call was filled
> > with params simply by
> >
> >
> >
> > params[0] = &arg1;
> >
> >
> >
> > In PHP7 this is changed to
> >
> >
> >
> > ZVAL_COPY_VALUE(&params[0], arg1);
> >
> >
> >
> > After function is executed (zend_call_function) both fci.params and
> > arg1 contain still the original zval values,
> >
> > changes made in PHP code are not available. Is there any way how to
> > solve this?
> >
> > I am mainly searching for and comparing code snippets in PHP/ext
> > folder to see how things were rewritten from PHP5 to PHP7.
> >
> > Sorry if I missed something obvious and thank you for your help.
> >
>
> It looks like the implementation of zend_call_method() does not support
> this, as it does not copy parameters back after the call. I'd suggest to
> use the lower level zend_call_function() for the cases where you need this
> for now.
>
> Nikita
>
>
>
>

--00000000000033aff7059bb3fc6d--