Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108026
MIME-Version: 1.0
Date: Tue, 7 Jan 2020 21:57:44 +0100
Message-ID: <CAFPFaM+jztyaVeZ8WWa5WabkA7N1pf+D3-dhbAykgQQ14M07TQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000db294d059b93076b"
Subject: Adding TypeError and ValueError to count() function
From: girgias@php.net (George Peter Banyard)

--000000000000db294d059b93076b
Content-Type: text/plain; charset="UTF-8"

Greetings internals,

I would like your input on adding TypeError and ValueError exceptions
to the count() function in respect to the Consistent type errors for
internal functions RFC [1], the initial PR [2] was denied as null was
not accepted as a value when it seems to be prevalent to use count()
as a substitute for isset() (this is currently done in the test runner
for php-src), although a "type error" warning was already emitted with
null.

So I've made an adjustment by still accepting null but deprecating it's
usage. An other option is to allow null as a value that always return 0.

I've also added a ValueError exception on invalid modes.
The new pull request is located at https://github.com/php/php-src/pull/4940

Any comments would be appreciated.

Best regards and happy new year.

George Peter Banyard

[1] https://wiki.php.net/rfc/consistent_type_errors
[2] https://github.com/php/php-src/pull/4572

--000000000000db294d059b93076b--