Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:108004
MIME-Version: 1.0
References: <CAP=4hCKg2efDty5hsttskG9DiuemhbEvYn1p9PtuUpBAiMr91A@mail.gmail.com>
 <CAFPFaMLp9CeD4NRGjBND6TBYkTCuNAi_5KW2XKervoJVjjuPOw@mail.gmail.com>
In-Reply-To: <CAFPFaMLp9CeD4NRGjBND6TBYkTCuNAi_5KW2XKervoJVjjuPOw@mail.gmail.com>
Date: Mon, 6 Jan 2020 10:29:17 +0100
Message-ID: <CAP=4hCJd4asnooF_D5GkGZk1GFjcmCDmJNW6YYyMuC7Dwgv4cA@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c2aada059b754b26"
Subject: Re: [PHP-DEV] Ensure correct signatures for PHP magic methods
From: carusogabriel34@gmail.com (Gabriel Caruso)

--000000000000c2aada059b754b26
Content-Type: text/plain; charset="UTF-8"

Hello George

On Mon, 6 Jan 2020 at 01:28, G. P. B. <george.banyard@gmail.com> wrote:

> On Sun, 5 Jan 2020 at 18:44, Gabriel Caruso <carusogabriel34@gmail.com>
> wrote:
>
>> Hello Internals,
>>
>> I have a PR proposing to start checking the signatures for PHP magic
>> methods in the next major version of PHP:
>> https://github.com/php/php-src/pull/4177. The idea for this PR came from
>> https://bugs.php.net/bug.php?id=69718.
>>
>> I'd like to hear your opinion before putting more effort into this :)
>>
>> Best regards.
>>
>
> Hello Gabriel,
>
> I do like the idea, but I would agree that I'd want void as the return
> type instead of a no return compile error.
> Other than that +1 from my side.
>


The reason why I didn't want to go with `__construct(): void`, for example,
is because some articles that I've read say that Constructors and
Destructors do not return anything:

- https://www.geeksforgeeks.org/php-constructors-and-destructors/
- https://docs.phpdoc.org/references/phpdoc/tags/return.html
- https://stackoverflow.com/questions/11904255/constructor-returning-value

Also, the community has pushing this standard, as it can be seen in
https://github.com/slevomat/coding-standard#slevomatcodingstandardtypehintsreturntypehint-
.

Best regards,


>
> Best regards
>
> George P. Banyard
>

--000000000000c2aada059b754b26--