Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:108001 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 51304 invoked from network); 6 Jan 2020 11:00:17 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 6 Jan 2020 11:00:17 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 7DD5118050B for ; Mon, 6 Jan 2020 01:05:07 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 6 Jan 2020 01:05:06 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id v201so35847345lfa.11 for ; Mon, 06 Jan 2020 01:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oVEW1x2VJaIWs5oRdXHpU1uWOHlppsHCECKJ7Nwqe8g=; b=JmZ869/bbfaww5FBp0NZfvi8gBmiNOGoHhMLa2ksIOyBG11GsixebO0fOii+35qwpn +Jiqi9R74ntntfpoWlTUqgXXu/Qmm1eHNc207evhbipoHghfXse4lgGEUPqoE+l9qNrz /+Wt0dcJiwoxIqFBWPkhr/irT4E4+cGhmSigqJEcQKv01ZK/x4wRNP/88LuuQzRjKXT4 CmwFHFhydN/UN/bkHvHP2gcBjJztznD2hfrzxE08vhK4Ohv5m5mcbEwLMY+VjEcRjXse rfIuUDrwdqi0+tyRV/XnZpM32WFCLThEyY+f4lumMZj0rEXTFN++dVlGrKRyQBqMeuVx k+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oVEW1x2VJaIWs5oRdXHpU1uWOHlppsHCECKJ7Nwqe8g=; b=EgW/CEyJ+l8Hw0hAXLdTIKxPfAm8w8wA5xQzLfCeZV0KAMe5YqDynsBdL7t3m+U9sX PV1IrsZXC5c0+a2U9n0Ff0p8A3fmlE+BUsHU656W7xHc4PT8DOtGqwhjlRq6IxyGIcS7 TB5r8KnrLvecHZmchK60XdjN2GLCYG4QfBnp2N0wzKStOUZECw1lKWlxCpLxmW2AbiIv Pbn3mp9bK2wcleaZ2H1kDaZAuWInpLl7ac8U0sB/g3NyjwSgA9pwP2ey/NRRBw2+YNr8 XB7vzpL495ivGVYLlDYah989QB1Ka/49jPKTJdsumw8haYBOidFxLB3Ge3ux/AiGwZLv hPiA== X-Gm-Message-State: APjAAAWwScoRmYA5KTp7p5JN5PVEj9WYle/t0YaVoXEuSR4jHhZsutjK y9nN4BG/T5lo3//IE234wK/7QmSQ/++jCtDzQs8= X-Google-Smtp-Source: APXvYqzzneWXxZG6Qcmi95dIGZiyoce/slpzpftudQTD3ycDpQlZnz3S4uadgbND8xoXRaO+BYysIdZXHewLlQ7G4d0= X-Received: by 2002:a19:6d13:: with SMTP id i19mr57077886lfc.6.1578301504604; Mon, 06 Jan 2020 01:05:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 6 Jan 2020 10:04:48 +0100 Message-ID: To: Gabriel Caruso Cc: PHP Internals Content-Type: multipart/alternative; boundary="00000000000087cde6059b74f47f" Subject: Re: [PHP-DEV] Ensure correct signatures for PHP magic methods From: nikita.ppv@gmail.com (Nikita Popov) --00000000000087cde6059b74f47f Content-Type: text/plain; charset="UTF-8" On Sun, Jan 5, 2020 at 6:44 PM Gabriel Caruso wrote: > Hello Internals, > > I have a PR proposing to start checking the signatures for PHP magic > methods in the next major version of PHP: > https://github.com/php/php-src/pull/4177. The idea for this PR came from > https://bugs.php.net/bug.php?id=69718. > > I'd like to hear your opinion before putting more effort into this :) > > Best regards. > To be clear, the suggestion here is to verify that no *wrong* types are specified -- but not specifying a type at all remains legal, right? If so, sounds reasonable to me. Nikita --00000000000087cde6059b74f47f--