Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107978
MIME-Version: 1.0
References: <DM5PR07MB30672DEC89A0351460769702F9230@DM5PR07MB3067.namprd07.prod.outlook.com>
 <CALKiJKr7d=qKoRAd3xhPQXzMWpQPLoX4QCxU6WyAM+2C5Y0LVg@mail.gmail.com>
 <DM5PR07MB3067CA908C15F6C4EBE2AA3FF9230@DM5PR07MB3067.namprd07.prod.outlook.com>
 <CALKiJKoN5auc6z4Z_67OdOqLhxfgdJBB8=-LG5L_4=T3oijUzw@mail.gmail.com> <DM5PR07MB306759CCF5831739C923B28FF9230@DM5PR07MB3067.namprd07.prod.outlook.com>
In-Reply-To: <DM5PR07MB306759CCF5831739C923B28FF9230@DM5PR07MB3067.namprd07.prod.outlook.com>
Date: Fri, 3 Jan 2020 15:39:06 +0000
Message-ID: <CALKiJKr60h+4Rh=hq3_JvGyKyZfe6VGn7fHjmQpCvEOPZhXigw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d1b84f059b3e1ca5"
Subject: Re: [PHP-DEV] Autoloading functions/consts without a performance impact
From: rowan.collins@gmail.com (Rowan Tommins)

--000000000000d1b84f059b3e1ca5
Content-Type: text/plain; charset="UTF-8"

On Fri, 3 Jan 2020 at 15:21, tyson andre <tysonandre775@hotmail.com> wrote:

> > Now the behaviour of my program can completely change depending on which
> of
> > those functions I call first, which might even depend on user input.
> > Regardless of exactly how the cache works, that kind of unpredictability
> is
> > a recipe for disaster.
>
> It already does completely change depending on user input, without
> autoloading, in the same way.
>



Not really, the only way you could have the same dependency on call order
at the moment would be if it looked like this:

namespace Foo;
function one() {
    echo strlen('hello');
}
function two() {
    require_once 'functions/Foo/strlen.php';
}

At that point, it's pretty obvious that you're conditionally including a
definition, which is not the case with the original example.




> I assume you're arguing against autoloading without autoloading \NS\strlen
> every time
>


Yes, I'm saying that the autoloader should be called for each lookup, so
autoloading of Foo\strlen should come between checking if Foo\strlen is
defined, and checking if \strlen is defined.




>
> > The only way to make it predictable again is to pre-define the namespaced
> > function in my startup code, at which point I don't need function
> > autoloading.
>
> Other use cases would benefit from function autoloading, though.



Then maybe we should target the feature at those use cases - don't call the
autoloader *at all* unless we know the fully-qualified name, and give up
trying to "square the circle" by combining fallbacks with autoloading for
unqualified names?

Regards,
-- 
Rowan Tommins
[IMSoP]

--000000000000d1b84f059b3e1ca5--