Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107933
MIME-Version: 1.0
References: <49beea16-31ab-d7f9-54e6-8d46a5331f3d@gmail.com>
In-Reply-To: <49beea16-31ab-d7f9-54e6-8d46a5331f3d@gmail.com>
Date: Fri, 20 Dec 2019 01:33:49 +0100
Message-ID: <CAFPFaMKmbeXNRzJd7=6WJsJ4U+2PV4HJbyey3phfKef-Ves-Qw@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000854855059a17d5a6"
Subject: Re: [PHP-DEV] Changelog / upgrading notes for promoted warnings
From: george.banyard@gmail.com ("G. P. B.")

--000000000000854855059a17d5a6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 19 Dec 2019, 21:17 Rowan Tommins, <rowan.collins@gmail.com> wrote:

> Hi all,
>
> Earlier, I was writing an application-specific wrapper around the
> password_hash function, and was surprised that it could return false,
> rather than throwing an error.
>
> I then found this commit to master making it throw errors for PHP 8.0:
> https://github.com/php/php-src/commit/37c11714
>
> That's great! But ... it is a breaking change, and I can't see any note
> in UPGRADING. Is there a running list of the Warnings that have been
> promoted to Errors anywhere, and if not, should we create one before we
> forget?
>
> Regards,
>
> --
> Rowan Tommins (n=C3=A9 Collins)
> [IMSoP]
>

As there are a lot more of these promotion, from what I recall, is that a
general upgrading note will be added.
As the promotions cover case which are clear programming/logic errors and
thus shouldn't arise in production code.

An example of a promotion is an invalid flag value (e.g. a mode with fopen
which does not exist) or out of bound values (usually integer value which
need to be greater than zero).

Moreover, I'm not sure it's helpful to have a massive list of functions
where some warnings have been promoted and others not. But this is only my
opinion.

Best regards

George P. Banyard

>

--000000000000854855059a17d5a6--