Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107932
MIME-Version: 1.0
Date: Fri, 20 Dec 2019 00:05:44 +0100
Message-ID: <CAH5C8xXnubQv-7CoAR=vjH1qXCmy6omF-8qQktd+QGFvAwQL0Q@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000821c29059a169a41"
Subject: Re: Changelog / upgrading notes for promoted warnings
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000821c29059a169a41
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> Hi all,
>
> Earlier, I was writing an application-specific wrapper around the
> password_hash function, and was surprised that it could return false,
> rather than throwing an error.
>
> I then found this commit to master making it throw errors for PHP 8.0:
> https://github.com/php/php-src/commit/37c11714
>
> That's great! But ... it is a breaking change, and I can't see any note
> in UPGRADING. Is there a running list of the Warnings that have been
> promoted to Errors anywhere, and if not, should we create one before we
> forget?
>
> Regards,
>
> --
> Rowan Tommins (n=C3=A9 Collins)
> [IMSoP]

Hi Rowan,

You are completely right, these should be (should have been) noted
somewhere.

Although, the only problem I have with including every promoted warning in
the upgrading notes
is that doing so would possibly cannibalise it as there are dozens (if not
hundreds) of
promotions that have already taken place...

Nevertheless, I'm happy to help collecting the converted warnings and
putting the list in either
the upgrading notes or any other place - whatever is going to be decided.

M=C3=A1t=C3=A9

--000000000000821c29059a169a41--