Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107914
MIME-Version: 1.0
References: <CAF+90c8fV4HkQSHWGKB4mVN94VR9=F97RGsWeT3brCM1PhM2JQ@mail.gmail.com>
 <CAF+90c_+uxb4i+TaqHu0FB0RL1J-44rr8A-qtQWOnqQS9x-cPw@mail.gmail.com>
 <1d2d5c23-3864-a202-92a8-34228798510d@birkholz.biz> <CAF+90c_mhnsTTBAOzb-VettKEamXXBVykcefnTVxvZ48LmdA1g@mail.gmail.com>
 <ddf9cfa3-73f4-a088-2128-566dcc9deb81@birkholz.biz> <CAF+90c90rJdg0KM-RbpSKxov1khZeL1F2HepexEWaoJSCHPZeQ@mail.gmail.com>
 <ceac6881-a86d-4025-b549-42b8fbbe6d40@birkholz.biz>
In-Reply-To: <ceac6881-a86d-4025-b549-42b8fbbe6d40@birkholz.biz>
Date: Mon, 16 Dec 2019 10:27:36 +0100
Message-ID: <CAF+90c-Hpuu8iGzuHmMRfMCdKpnpL230N8Hybvz4Bo2=76CHAw@mail.gmail.com>
To: Dennis Birkholz <php@dennis.birkholz.biz>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006698170599ced34d"
Subject: Re: [PHP-DEV] Re: [RFC] Add WeakMap
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000006698170599ced34d
Content-Type: text/plain; charset="UTF-8"

On Mon, Dec 16, 2019 at 10:19 AM Dennis Birkholz <php@dennis.birkholz.biz>
wrote:

> On 12.12.19 18:13, Nikita Popov wrote:
> > On Tue, Dec 10, 2019 at 12:03 PM Dennis Birkholz <
> php@dennis.birkholz.biz>
> > wrote:
> >> But my just want to repeat my main concern: buildin
> >> data structures that are not serializable are a real problem for users
> >> that use serialization extensively. Maybe the solution to that problem
> >> is a method to check whether a provided object graph can be serialized
> >> (which may not be possible due to throwing an exception in __sleep() or
> >> something like that), some way to ignore unserializable elements or some
> >> way to register callback methods to handle unserializable elements.
> >>
> >
> > I'm must be missing something obvious here: Isn't this a reliable way to
> > detect whether an object graph is serializable?
> >
> > try {
> >      $serialized = serialize($value);
> > } catch (\Throwable $e) {
> >      // not serializable
> > }
>
> Checking whether the serialization process worked is different from
> checking beforehand whether an object graph is serializable as it makes
> it a lot easier to display a meaningful error message. Something like
> the Serializable interface in Java. But that seems to not be the PHP way
> so far, I will have to think about an RFC for a second parameter for
> serialize() that accepts a callback that can "serialize"
> objects/variables that fail to serialize themselves...
>

Could you please explain in more detail what the practical distinction
between checking beforehand and catching an exception is? It seems like the
exception should be sufficient to display a meaningful error message --
heck, it already contains an error message you can use.

Nikita

--0000000000006698170599ced34d--