Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107855
To: "Christoph M. Becker" <cmbecker69@gmx.de>,
 PHP internals <internals@lists.php.net>
References: <f61573e3-a3db-a266-153f-70b87802291f@gmx.de>
 <6fbd8905-a415-c723-dc87-ba7209539c0c@gmx.de>
Message-ID: <261a9e80-8b88-2147-7a23-128621795f39@xs4all.nl>
Date: Sun, 24 Nov 2019 22:52:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <6fbd8905-a415-c723-dc87-ba7209539c0c@gmx.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: file_cache is prone to some configuration changes
From: d.takken@xs4all.nl (Dik Takken)

On 19-11-19 10:44, Christoph M. Becker wrote:
> On 06.11.2019 at 14:02, Christoph M. Becker wrote:
> 
>> while having had a closer look at <https://bugs.php.net/78754>, I
>> learned that OPcache's file_cache is prone to some configuration
>> changes, which may cause PHP segfaults (and maybe other malfunctions).
>> For instance, if Xdebug is enabled while a file is compiled, but later
>> disabled when executing that file, the process is segfaulting because
>> the cached file relies on user opcode handlers which are no longer
>> available without Xdebug loaded.  I'm presenting Xdebug as example
>> because that likely caused the issues reported in that ticket, but
>> basically any extension can call zend_set_user_opcode_handler() to
>> install user opcode handlers, causing the same problems.
>>
>> It should be mentioned that, to my knowledge, shared memory caches are
>> not affected by this (except for Windows), because re-attaching a
>> differently configured php instance isn't possible at all.
>>
>> Anyhow, should we fix this (assuming a general fix would be possible),
>> or would that be rather a documentation issue, based on the assumption
>> that such configuration changes don't make sense in combination with
>> OPcache at all (IOW, if such changes are done, users should reset OPcache)..
> 
> Any thoughts regarding this issue?
> 

Hi,

My knowledge of opcache is limited, so please forgive me if the
following is incomplete or incorrect. My impression is that the amount
of information that is used to compute the hash for the file cache
directory is a bit low. I see the PHP version go in, an internal API
version and some machine architecture related things.

I would have expected that much - if not all - of the output of
phpinfo() would be included in the hash for example. Better be safe than
sorry. Would that be a sane thing to do? Are there any reasons why this
is currently not done?

Thanks,

Dik Takken