Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107852
MIME-Version: 1.0
References: <77a3eec4-275f-e2d9-1969-185abeab7f5d@aimeos.com>
In-Reply-To: <77a3eec4-275f-e2d9-1969-185abeab7f5d@aimeos.com>
Date: Sun, 24 Nov 2019 13:52:37 +0100
Message-ID: <CADyq6sKYCEtw5H01DEzaox57XUnF6wsjyLkD5eH4q88p4paSEA@mail.gmail.com>
To: "Aimeos | Norbert Sendetzky" <norbert@aimeos.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000deeea80598171f45"
Subject: Re: [PHP-DEV] Extend ArrayObject class
From: ocramius@gmail.com (Marco Pivetta)

--000000000000deeea80598171f45
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 24, 2019, 13:16 Aimeos | Norbert Sendetzky <norbert@aimeos.com>
wrote:

> The ArrayObject class is only rarely used at the moment due to a lack
> for almost all array_* functions beside the sort functions.
>
> Currently implemented by ArrayObject:
> https://www.php.net/manual/en/class.arrayobject.php
>
> Missing methods that would be most useful:
> array_=E2=80=8Bchunk
> array_=E2=80=8Bcolumn
> array_=E2=80=8Bdiff_=E2=80=8Bassoc
> array_=E2=80=8Bdiff_=E2=80=8Bkey
> array_=E2=80=8Bdiff_=E2=80=8Buassoc
> array_=E2=80=8Bdiff_=E2=80=8Bukey
> array_=E2=80=8Bdiff
> array_=E2=80=8Bfilter
> array_=E2=80=8Bflip
> array_=E2=80=8Bintersect_=E2=80=8Bassoc
> array_=E2=80=8Bintersect_=E2=80=8Bkey
> array_=E2=80=8Bintersect_=E2=80=8Buassoc
> array_=E2=80=8Bintersect_=E2=80=8Bukey
> array_=E2=80=8Bintersect
> array_=E2=80=8Bkey_=E2=80=8Bfirst
> array_=E2=80=8Bkey_=E2=80=8Blast
> array_=E2=80=8Bkeys
> array_=E2=80=8Bmap
> array_=E2=80=8Bmerge
> array_=E2=80=8Bpop
> array_=E2=80=8Bpush
> array_=E2=80=8Brand
> array_=E2=80=8Breduce
> array_=E2=80=8Breplace_=E2=80=8Brecursive
> array_=E2=80=8Breplace
> array_=E2=80=8Breverse
> array_=E2=80=8Bsearch
> array_=E2=80=8Bshift
> array_=E2=80=8Bslice
> array_=E2=80=8Bsplice
> array_=E2=80=8Bunique
> array_=E2=80=8Bunshift
> array_=E2=80=8Bvalues
> shuffle
>
>
> Furthermore, the already existing sort functions return VOID, which
> isn't best for an object. Instead, returning the ArrayObject itself to
> support a fluid interface would be much better, i.e.:
>
> $ao =3D new \ArrayObject([null, 'a' =3D> 2, 'b' =3D> 1]);
> $ao->filter()->sort()->flip();
>
> This change wouldn't break any existing code already using the ArrayObjec=
t.
>
>
> It should be possible to extend from ArrayObject too and have access to
> the internal array. Therefore, a new method would be required:
>
> protected getArrayRef() : array
>
> The method is similar to the existing getArrayCopy() method but returns
> a reference to the internal array instead of a copy. Thus, classes
> extending ArrayObject will be able to implement additional methods
> efficiently without the need to create copies of the internal array first=
.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.ph
> <http://www.php.net/unsub.php>



Ouff, please don't extend `ArrayObject`: it is very quirky and keeps state
in a way that is very much untransparent to userland: please use
`ArrayAccess` instead.

Even then, the various `array_` functions that mutate/map/filter would need
to produce equivalent data structures by knowing the ctor of your
array-alike object: better leave them alone, unless the output is a core
`array` again

--000000000000deeea80598171f45--