Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:10781
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sat, 26 Jun 2004 01:24:23 -0700 (PDT)
To: Stefan Esser <sesser@php.net>
cc: internals@lists.php.net
In-Reply-To: <40DC70CB.5010400@php.net>
Message-ID: <Pine.LNX.4.58.0406260120430.2332@thinkpad.lerdorf.com>
References: <40DC70CB.5010400@php.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] Input Filters - Bugs? - PHP4 Port
From: rasmus@php.net (Rasmus Lerdorf)

On Fri, 25 Jun 2004, Stefan Esser wrote:
> am I correct in assuming that input_filters are allowed todo whatever 
> they want with the value?
>
> I am asking, because this is not properly documented and atleast the 
> mbstring extension violates this.
> 
> First of all it feeds input_filter a value pointer that is NOT allocated 
> with emalloc and secondly it free()s the wrong address in case the 
> input_filter has erealloc()ated value (but most probably the erealloc() 
> will already crash because the memory is allocated with malloc() instead 
> of emalloc())

Yeah, this should probably be more strictly defined.  I think I am 
probably the only one using this and my filters never grow the string so I 
don't have these problems.

> And the second question is: Is there any argument against backporting 
> the input_filter functionality to PHP4? I do not know what the plans 
> are, but I doubt PHP4 will die out with the release of PHP5 and so the 
> question is if we partly backport new functionality for PHP4 from PHP5 
> into PHP 4.4

No real porting necessary.  This area of the code is identical in PHP4 and 
PHP5, so it would just be a matter of adding the hook.  I am using this 
extensively with PHP4.

-Rasmus