Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107794
To: pgnet.dev@gmail.com, internals@lists.php.net
Cc: sterling@php.net
References: <14576377-3d3e-ac7a-6f8f-94f08c30eb06@gmail.com>
Message-ID: <67b3470a-dc84-095f-d7b5-f84a30559e2e@gmx.de>
Date: Fri, 15 Nov 2019 09:18:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <14576377-3d3e-ac7a-6f8f-94f08c30eb06@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: =?UTF-8?Q?Re=3a_php_7=2e=7b3=2c4=7d/git_ext/curl_builds_FAIL_with_r?=
 =?UTF-8?Q?ecent_curl/libcurl_7=2e67+=3a_=22error=3a_=e2=80=98CURLE=5fOBSOLE?=
 =?UTF-8?B?VEUyMOKAmSB1bmRlY2xhcmVkIC4uLiIu?=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 15.11.2019 at 05:56, PGNet Dev wrote:

> I needed to bump local curl build version to fix a (php-unrelated) SEGV.=
  Currently, I have
>
> 	curl -V
> 		curl 7.67.1-DEV (x86_64-pc-linux-gnu) libcurl/7.67.1-DEV OpenSSL/1.1.1=
d zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) li=
bssh2/1.9.0_DEV nghttp2/1.40.0-DEV
> 		Release-Date: [unreleased]
> 		Protocols: dict file ftp ftps http https imap imaps pop3 pop3s scp sft=
p smtp smtps tftp
> 		Features: AsynchDNS brotli HTTP2 HTTPS-proxy IDN IPv6 Largefile libz M=
etalink NTLM NTLM_WB PSL SSL TLS-SRP UnixSockets
>
> Rebuilding my usual PHP7.3/git install,
> (add'l note: fwiw, the following issue also occurs with 7.4/git ...)
>
> 	cd php7
>
> 	git branch -a | grep \*
> 		* PHP-7.3
>
> 	git log | head
> 		commit 9083e178f656878cab46aee52b555346ef92a768
> 		Author: Dmitry Stogov <dmitry@zend.com>
> 		Date:   Tue Nov 12 12:59:50 2019 +0300
>
> 		    Fixed wrong constant usage
>
> 		commit ea2a125789d2e6cf7416bd706be1ac44df1367e4
> 		Merge: 4a55794b98 2c9926f156
> 		Author: Stanislav Malyshev <stas@php.net>
> 		Date:   Mon Nov 11 23:08:38 2019 -0800
>
> works nicely as usual,
>
> 	/usr/local/php7/bin/php -v
> 		PHP 7.3.13-dev (cli) (built: Nov 14 2019 19:53:24) ( NTS )
> 		Copyright (c) 1997-2018 The PHP Group
> 		Zend Engine v3.3.13-dev, Copyright (c) 1998-2018 Zend Technologies
> 		    with Zend OPcache v7.3.13-dev, Copyright (c) 1999-2018, by Zend Te=
chnologies
>
> But curl extension now fails,
>
> 	ext/curl/interface.c:778:25: error: =E2=80=98CURLE_OBSOLETE20=E2=80=99 =
undeclared (first use in this function); did you mean =E2=80=98CURLE_OBSOL=
ETE50=E2=80=99?
> 			  778 |  REGISTER_CURL_CONSTANT(CURLE_FTP_WRITE_ERROR);
>
>
> Before making noise about in @bugs, wanted to check 1st; known issue? ad=
ditional/new config req'd?

That appears to be due to a recent change in libcurl[1].  We'll have to
work around that, but I'm not sure how.  Define both constants for BC?

[1]
<https://github.com/curl/curl/blob/b3eb7d172aab6c7f423aea2f97c27099d6b65f7=
a/include/curl/curl.h#L504-L506>

=2D-
Christoph M. Becker