Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107615
Message-ID: <17D060DE-C095-400A-862C-5231B86104C6@newclarity.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_A655A939-DA74-4AA3-8C20-74600FAC6043"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Mon, 21 Oct 2019 16:33:40 -0400
In-Reply-To: <CALKiJKp64cBUDSOdaz9sJ3SxjoeJO26vH6iVF0tMrBwLK8=j0w@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
To: Rowan Tommins <rowan.collins@gmail.com>
References: <CAP=w73VJ6pxstVzyfFkOp=esX7ne-LosWP1Eb8Ac0u-JeROPRA@mail.gmail.com>
 <bd36083e-a84d-69e1-725c-7b026a009be1@gmail.com>
 <91095002-BA0D-440B-8FAB-AA003A0EDB69@newclarity.net>
 <CALKiJKp64cBUDSOdaz9sJ3SxjoeJO26vH6iVF0tMrBwLK8=j0w@mail.gmail.com>
Subject: Re: [PHP-DEV] 'switch-expression' and the 'type guard' unary operator
 demo
From: mike@newclarity.net (Mike Schinkel)

--Apple-Mail=_A655A939-DA74-4AA3-8C20-74600FAC6043
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On Oct 21, 2019, at 4:51 AM, Rowan Tommins <rowan.collins@gmail.com> =
wrote:
>=20
> On Sun, 20 Oct 2019 at 22:35, Mike Schinkel <mike@newclarity.net> =
wrote:
>> I would much prefer to use a switch for multiple, mutually exclusive =
cases
>> no matter what how complex the expression is because with a switch =
the
>> cases expressions line up vertically. With `if` and `else if` it is =
harder
>> to vertically eyeball the different mutually exclusive cases.
>=20
> I've never particularly been bothered by it, but wouldn't adding four
> spaces in your "if" statement make it line up with all your "elseif"
> statements?

Possibly, but then again I am:

1) Mostly reading other people's code who will not have formatted their =
IFs that way, and=20
2.) Using a code reformatter to standardize code format via my IDE and =
there is no option for that.

As for #1, I know I cannot enforce switch usage outside my own team, but =
at least for own team our standard says "use switch for multiple =
expressions" when possible so at least it would provide we can have =
consistency across our team.

>> But how often will we have this use-case?  Only for global variables,
>> which hopefully will eventually become extinct in userland code.
>=20
> Not just global variables, no;...

Fair point.

>> That said, we should almost be able to do *both*, and just let PHP =
throw
>> an error if there is a problem. This would be useful if you know 100% =
that
>> the code won't fail because of the code that came before it:
>>=20
>> if ( is_numeric($_GET['id'] ?? 0 ) ) {
>>    $id =3D intvar($_GET['id'] ?? 0);
>>     $user =3D getUser(<int>$id):
>> }
>=20
> I'm not sure what the point of this example is. You've just cast to =
int, so
> the assertion can never fail, and if getUser has a type hint, it's =
about to
> make that assertion anyway.

Yeah, I know. I could not come up with a great example on the spot.

I'll have to go off and do some more coding because that's when I always =
come across the good examples. Which is usually not the same time I need =
the good example. :-(

-Mike=

--Apple-Mail=_A655A939-DA74-4AA3-8C20-74600FAC6043--