Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107613
MIME-Version: 1.0
References: <CAJaRsPvTvZVWtszNH-uqaOc8487ncGjKdgFikzq60gUhvTNMtQ@mail.gmail.com>
 <CAF+90c8=Fd2eaEB=fRGe=GtD7S89__VT5v7LnCR92-CM8vZbGQ@mail.gmail.com>
In-Reply-To: <CAF+90c8=Fd2eaEB=fRGe=GtD7S89__VT5v7LnCR92-CM8vZbGQ@mail.gmail.com>
Date: Mon, 21 Oct 2019 15:11:07 -0400
Message-ID: <CAJaRsPtMjkTxe2DJ4dtSPg9O-7ot52e8iiW2hUFDkxqxgnxWPg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d96f9005957072b7"
Subject: Re: [PHP-DEV] substr with null length
From: colinodell@gmail.com ("Colin O'Dell")

--000000000000d96f9005957072b7
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 21, 2019 at 11:29 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> This is a fairly common deficiency in the implementation of internal
> functions. Part of the reason is that historically zend_parse_parameters
> did not support the ! modifier for integers, and partly these are just
> implementation oversights.
>
> Feel free to send a PR to fix this for PHP 8, no RFC needed. If you're
> interested in addressing this for more functions, do a grep for "= UNKNOWN"
> on the codebase, which gives you (with a few exceptions) a list of
> functions that currently handle null parameters incorrectly and should
> ideally be fixed for PHP 8.
>
>
Thank you so much for that guidance!  I wasn't sure about the RFC as it's
technically a behavioral change, but I agree with you (and Christoph) and
have therefore submitted a pull request with this change:
https://github.com/php/php-src/pull/4840  I'll also take a look at those
other functions and see if I can assist with adjusting those other
instances as well.

Cheers,

Colin O'Dell
colinodell@gmail.com

--000000000000d96f9005957072b7--