Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107556
MIME-Version: 1.0
References: <CAEsg9X0Tmkzxz9x2KgwNbPNdbmMz=a0J7Rt84Lh10W=3GQpRkA@mail.gmail.com>
 <CABdc3WqEzFV4ytrVtJB8OS2=3VMuNsHR7MqsTAHsg8-U==CkWA@mail.gmail.com>
 <CAP=w73X4sBBFtn=Z1OKfo0cdSZbd1-fst+5MFs5+8m2pEMxQew@mail.gmail.com> <CABdc3WpdXSCid0y4tizf8hoXUtSW+rqiDwk82ZGunNtp-ypytA@mail.gmail.com>
In-Reply-To: <CABdc3WpdXSCid0y4tizf8hoXUtSW+rqiDwk82ZGunNtp-ypytA@mail.gmail.com>
Date: Wed, 16 Oct 2019 15:37:13 +0700
Message-ID: <CAP=w73XE-ruRkPHwY777BctDaHDMFApzQBn8nCOtdkmW69GiWg@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Brzuchalski?= <michal.brzuchalski@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000aff5f205950302e4"
Subject: Re: [PHP-DEV] Inline switch as alternative to nested inline conditional
From: webdevxp.com@gmail.com (Kosit Supanyo)

--000000000000aff5f205950302e4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I mean separation between cases not case conditions. Examples in your RFC
uses semicolon as case separator instead of comma.

<?php
$say =3D switch (date("w")) {
    case 0 =3D> "weekend!";
    case 1, 2, 3, 4, 5 =3D> "weekday :(";
    case 6 =3D> "weekend!";
};
echo "Today is {$say}";

I prefer comma because semicolon should only be used to separate statements
but switch expression is list of condition/expression pairs not statements.
So it should be:

 <?php
$say =3D switch (date("w")) {
    case 0 =3D> "weekend!",
    case 1, 2, 3, 4, 5 =3D> "weekday :(",
    case 6 =3D> "weekend!",
};
echo "Today is {$say}";

You may think t's fine because Java uses semicolon but IMO Java had made a
mistake. (C# is semantically correct)

Cheers

On Wed, Oct 16, 2019 at 2:54 PM Micha=C5=82 Brzuchalski <
michal.brzuchalski@gmail.com> wrote:

> Hi Kosit,
>
> =C5=9Br., 16 pa=C5=BA 2019 o 09:41 Kosit Supanyo <webdevxp.com@gmail.com>
> napisa=C5=82(a):
>
>> Hi Michal
>>
>> I'had the idea similar to your RFC but instead of using `switch` keyword
>> I think introducing `when` keyword is better. (as I know a language that
>> uses this keyword is Kotlin)
>>
>> $result =3D when ($v) {
>>     'foo' =3D> 1,
>>     'bar' =3D> 2,
>>     'x', 'y', 'z' =3D> 3,
>>     default =3D> null,
>> };
>>
>> Above you can see that `when` syntax is more semantic than `switch`. And
>> it is easier to implement in parser because it has no statement/expressi=
on
>> ambiguity.
>>
>> But this might not be preferred by BC camps because introducing a new
>> keyword might break BC.
>> And if `switch` is chosen I still think the syntax should be comma
>> separated instead of semicolon separated for consistency with other list
>> expressions (array/function call).
>>
>> $result =3D switch ($v) {
>>     case 'foo' =3D> 1,
>>     case 'bar' =3D> 2,
>>     case 'x', 'y', 'x' =3D> 3,
>>     default =3D> null,
>> };
>>
>
> That's exactly my proposal with commas, see here:
> https://wiki.php.net/rfc/switch-expression-and-statement-improvement#swit=
ch_expression_introduction
> Unfortunately, this RFC needs more work cause it mixes switch statement
> enhancement with comma-separated list syntax and of switch statement - I
> need to split it into two RFC's
>
> This is nice hearing that this idea has an interest.
> As soon as the RFC will be split and finished I can start a discussion
> thread.
>
> Cheers,
> Micha=C5=82 Brzuchalski
>

--000000000000aff5f205950302e4--