Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:107546 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 62870 invoked from network); 14 Oct 2019 16:28:53 -0000 Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12) by pb1.pair.com with SMTP; 14 Oct 2019 16:28:53 -0000 Received: from php-smtp3.php.net (localhost [127.0.0.1]) by php-smtp3.php.net (Postfix) with ESMTP id 43C7D2CB91C for ; Mon, 14 Oct 2019 07:12:48 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: X-Spam-Virus: No Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp3.php.net (Postfix) with ESMTPS for ; Mon, 14 Oct 2019 07:12:47 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id n14so16768385ljj.10 for ; Mon, 14 Oct 2019 07:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c9ccnTr4XqGXgQbw+2cGaxpOcpQppMGaMbK5srDtnR8=; b=Oiszfg2nk/fnVisO/pYGpaoeXVX/flYgHTPOrPWETm2bwn0YQspAbCnwqi/6SK1gZU hRtCbi41ADLM0iDp9F5TM0Gkxkr2V5mpCH28QFmIvRgG7A+xQVrSik+a8Jgz+hwxdWd4 Evu2Z5CIoKRgWbU9+QGihTP3HRyVUD6Nvyv4SuCaxxAQXQhQi3sGxkquaTp+E02ifXFF 5zOe7sksHfuzhtVwgndmKEzw/hgI0IVh6FKibR+XfxGSlZcPJ0/UzlJuC4tfouN+jzt3 CFdwVsXE1T+OzkGPSAE8hZ7yTQLN63Wi1q9iWtRINbVLVLPmW4ppoFTFX+rov/WZD2Ow ZkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c9ccnTr4XqGXgQbw+2cGaxpOcpQppMGaMbK5srDtnR8=; b=rAqsfRkesHf3TmI46pgcMLG0DDbVONhGh9s1cL8/zLsqbZeKBwf1BHk4uwPWK0YpcU y+UIgrMqlSt/SolVKR+yAnjdlvmSsopKi5j3eMoraC0cEY38ZRY9W3k3HcG71jU8/fMg m+vYg0dt00jLg9VpZwWwf5/PiEyhbfC2DHWFJ4EUa7qPmehOF6FafZiMHUkKjW+4NSIN 4EbpfaV5bpRKSSH4pdzL5U1FEzQb7a7QvIjTZua9M9CBD7asbXUxZX1XymIQEQ2jLq3L /cXZMZ+TVw0bx8T45ZyFuqqNlEh+ryQJZ0VlViAzjnb8I3vbnqTT8pFftC2OD7W//rwS 21UA== X-Gm-Message-State: APjAAAU0Seg6Lv6gC7D0LMxxTWZfMJp0ZWviC/rXgOHin6SPx9jh/60N 4w1a1JJydwiw2Kqqhs/fuFmJn4iY9nBnnWs9MqU= X-Google-Smtp-Source: APXvYqzRfFDZAdQt30euV3FNTHoVevReJvSOR0gADNs9FpzHR2PnU5jryqpwBmEj/scVF2r/IyGkVtr39mGSIzW20Cc= X-Received: by 2002:a2e:5d4f:: with SMTP id r76mr18645729ljb.150.1571062366242; Mon, 14 Oct 2019 07:12:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 14 Oct 2019 16:12:30 +0200 Message-ID: To: Gerard Roche Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000428ded0594df76e9" X-Envelope-From: Subject: Re: [PHP-DEV] Computing code coverage on Azure Pipelines From: nikita.ppv@gmail.com (Nikita Popov) --000000000000428ded0594df76e9 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 30, 2019 at 2:30 PM Gerard Roche wrote: > > gcov.php.net used to provide valgrind reports and code coverage for > > php-src. It no longer works with 7.4/8.0, because the OS is very old, and > > building new versions of PHP there gets very hard. The valgrind reports > > have essentially been subsumed by asan/ubsan on Azure Pipelines, but > we're > > still missing a replacement for code coverage. > > The index page for v7.4 and the master branch say the build failed but > it looks like the > valgrind and coverage reports are still generated: > > http://gcov.php.net/PHP_HEAD/lcov_html/ > > > The first step is probably to get code coverage working locally. We have > a > > ./configure --enable-gcov option and there's some extra make targets in > > build/Makefile.gcov. Maybe taking a look at what > > https://github.com/php/web-gcov/blob/master/cron/cron.sh does would > help. > > > > Second step is to add a new job in azure by copying > > https://github.com/php/php-src/blob/master/azure/job.yml and adding the > > necessary gcov/lcov magic there. > > > > The hard part if how to get those results published on Azure under the > > "Code coverage" tab. There is a PublishCodeCoverageResults task for this > > purpose, but I don't know how one would use that with lcov in particular. > > It seems to me that part of it requires a coverage overview in a specific > > format and part is just a directory with HTML, so maybe the result from > ltp > > genhtml can just be used there? Figuring out how to make this work is > > likely going to be "fun" ;) > > > > Nikita > > Is the intention to close down gcov.php.net completely? > > re: https://github.com/php/php-src/pull/4746 > Thanks for working on this! The code coverage support is merged now and is published daily on azure. Here's how it looks like: https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=3335&view=codecoverage-tab With that done, I think we can shut down gcov.php.net when PHP 7.3 goes EOL, which is the last version that still works there. Nikita --000000000000428ded0594df76e9--