Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107542
MIME-Version: 1.0
References: <c092bd28-f212-5ee2-36e7-368724480da3@evermeet.cx>
 <e93bb835-5489-01ef-b29d-189d48276af0@evermeet.cx> <CAEKnhAEgC1G-z9LjzdBCEThmEDpw0FU3Y=ErpSoPtkOpHnqg8g@mail.gmail.com>
 <2e358c47-f07d-2bd0-dcbf-8ee1282f1ea1@evermeet.cx> <CAEKnhAFN1TNsOSuOVC0gszL=4eBWfePq9XxqJweEwTnchwKOtw@mail.gmail.com>
 <79bdc208-876f-ea0c-b529-010fe3d129bb@kippdata.de> <6de046b4-905c-e338-d640-14973a448910@evermeet.cx>
 <6d37qe5jhtm390dqs45hmgpkdvlm3lgj3i@4ax.com> <CAF+90c8zR_yLrbZCczKEQAuTHYO+Hy_h4=qmOApRvGDpGzEJRg@mail.gmail.com>
 <c502257d-e568-5e5a-2880-4be3a3270f46@evermeet.cx> <CAF+90c8DzeECxghZgx9m1in1-GjsXsU-PFi=eot=dz45KcUPrw@mail.gmail.com>
In-Reply-To: <CAF+90c8DzeECxghZgx9m1in1-GjsXsU-PFi=eot=dz45KcUPrw@mail.gmail.com>
Date: Mon, 14 Oct 2019 11:30:42 +0200
Message-ID: <CAF+90c-aYPNPDSZziG4iAADNGk9n2v74boJm0=UrE1obSQgSZg@mail.gmail.com>
To: "Helmut K. C. Tessarek" <tessarek@evermeet.cx>
Cc: Jan Ehrhardt <phpdev@ehrhardt.nl>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007c0a140594db86d5"
Subject: Re: [PHP-DEV] configure bug with static openssl 1.1.1? - bugid 77288
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000007c0a140594db86d5
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 14, 2019 at 11:22 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Sun, Oct 13, 2019 at 11:04 PM Helmut K. C. Tessarek <
> tessarek@evermeet.cx> wrote:
>
>> On 2019-10-13 17:00, Nikita Popov wrote:
>> > Don't know about previous versions, but at least on 7.4 setting
>> > OPENSSL_CFLAGS and OPENSSL_LIBS appropriately (e.g. using pkg-config
>> > --static --cflags/--libs return values) should work. These environment
>> > variables allow you to bypass normal pkg-config checks, which are
>> generally
>> > going to be non-static.
>>
>> I've tried pretty much anything, so if you have flags and env vars that
>> work,
>> please post them here.
>>
>
> Here's what pkg-config --static tells me on my system:
>
> -lssl -lcrypto -ldl -pthread
>
> So I use this for OPENSSL_LIBS, while explicitly requesting the static .a
> libs (on the assumption that only openssl should be linked statically, not
> all libs):
>
> ./configure --disable-all --with-openssl OPENSSL_LIBS="-l:libssl.a
> -l:libcrypto.a -ldl -pthread"
>
> configure passes, but then during linking I get:
>
> /usr/bin/ld:
> /usr/lib/gcc/x86_64-linux-gnu/8/../../../x86_64-linux-gnu/libcrypto.a(threads_pthread.o):
> undefined reference to symbol 'pthread_rwlock_wrlock@@GLIBC_2.2.5'
>
> It looks like the "-pthread" flag gets stripped. Then I tried:
>
> ./configure --disable-all --with-openssl OPENSSL_LIBS="-l:libssl.a
> -l:libcrypto.a -ldl" CFLAGS="-pthread"
>
> This compiles successfully.
>
> > ldd sapi/cli/php
> linux-vdso.so.1 (0x00007ffd1531f000)
> libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007f04b79a9000)
> librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f04b77a1000)
> libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f04b7403000)
> libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f04b71ff000)
> libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0
> (0x00007f04b6fe0000)
> libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f04b6bef000)
> /lib64/ld-linux-x86-64.so.2 (0x00007f04b8bee000)
>
> The fact that "-pthread" gets stripped from LIBS might be a bug.
>

Looks like the -pthread stripping happens here:
https://github.com/php/php-src/blob/5197d0cd5e1f4581db1beca1260e1315368ea911/build/php.m4#L371-L377

It doesn't get stripped as much as relocated to EXTRA_LDFLAGS (for static
builds, for shared it goes into SHARED_LIBADD). However EXTRA_LDFLAGS is
only used when linking libraries, while programs use EXTRA_LDFLAGS_PROGRAM.
This seems like an oversight, and it should be added to both.

Nikita

--0000000000007c0a140594db86d5--