Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107504
Message-ID: <76F6996C-F254-47C3-AAD6-3338F38F30C6@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_7F272F9E-F37D-4829-9EFC-40D800E3BE64"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Fri, 11 Oct 2019 15:16:04 +0200
In-Reply-To: <CAF+90c9EQ+UGe-y+V_n1QrYkXtPh1uWKXXWEJQUe0xP-MjV7_w@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
To: Nikita Popov <nikita.ppv@gmail.com>
References: <CAF+90c9EQ+UGe-y+V_n1QrYkXtPh1uWKXXWEJQUe0xP-MjV7_w@mail.gmail.com>
Subject: Re: [PHP-DEV] exit() via exception
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_7F272F9E-F37D-4829-9EFC-40D800E3BE64
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 11 oct. 2019 =C3=A0 13:05, Nikita Popov <nikita.ppv@gmail.com> a =
=C3=A9crit :
>=20
> I'm mainly wondering how exactly we'd go about integrating this in the
> existing exception hierarchy. Assuming that it is desirable to allow =
people
> to actually catch this exception, my first thought would be along =
these
> lines:
>=20
> Throwable (convert to abstract class)
> \-> Exception
> \-> Error
> \-> ExitThrowable
>=20
> This does mean though that existing code using catch(Throwable) is =
going to
> catch exit()s as well. This can be avoided by introducing *yet =
another*
> super-class/interface above Throwable, which is something I'd rather =
avoid.


We should keep the semantics of `exit`, which is quite akin an early =
`return` in a function. Therefore:

* Executing finally blocks (as does an early `return`) would be an =
improvement.

* But intercepting it in a `catch` block or in an exception handler, is =
usually unwanted, contrarily to everything that currently implements =
`Throwable`.

But if you do want to allow exit signals to be caught in catch blocks, =
there is no absolute necessity to introduce yet another superclass or =
superinterface, because you can write (since PHP 7.1):=20

catch (\Throwable | \ExitSignal $e)

=E2=80=94Claude=

--Apple-Mail=_7F272F9E-F37D-4829-9EFC-40D800E3BE64--