Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:107364 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 7525 invoked from network); 2 Oct 2019 18:30:32 -0000 Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12) by pb1.pair.com with SMTP; 2 Oct 2019 18:30:32 -0000 Received: from php-smtp3.php.net (localhost [127.0.0.1]) by php-smtp3.php.net (Postfix) with ESMTP id B84022D19CA for ; Wed, 2 Oct 2019 09:11:28 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp3.php.net (Postfix) with ESMTPS for ; Wed, 2 Oct 2019 09:11:28 -0700 (PDT) Received: by mail-qk1-f182.google.com with SMTP id w2so15576919qkf.2 for ; Wed, 02 Oct 2019 09:11:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=oCcom8ivw23QYt6+DYMyctkX3rGcO3WE9OmlexET37g=; b=Vg6O1uWUgU0sUUov07qn5LTPFD7SvclYz4dUi4PEJKRsD60KssF1wmGPp/fwuKbxfc RUQnHIoE8RDDWDki2JwoDwqCct9qzXsXIGWBbux8yAkyyqIDsv6nx/yY9s3dqJRypt0r Gf9wf8BPyiVfigAa2iBvqImscjtbANIw+cUXuYlTc8PNAxEwn4waaV8WmdIyxTJEFqDX tlxgVhXnaPcIrwze4uPM4BEySo1HlOQjvtl0fWqt2u2FgikuDjS/ykaNq5yNyaRjANaM EGw6J87IsHsjKbiXZEnj2x0LK9wLsavUbnL4KvvgO089LoJEC3IEEmJooI7bD6k+k8/V lMpA== X-Gm-Message-State: APjAAAWzc4JKB0kj4yLjNz4qUGUubUULDu3j9q+acHsbzmo8nqwQBJt2 5TRYAFnzL29ZBvVwFK16YQ/QCRHnNfGcpIb2sjE= X-Google-Smtp-Source: APXvYqx1DGfekMat1alqdVfP5ZBg8Sb6hY2okfR0zyerwfqysV5cnUCom566wqovyNcOqyS/ksNRgpN9laDw/ZtxOLY= X-Received: by 2002:a37:4e48:: with SMTP id c69mr4526323qkb.182.1570032687586; Wed, 02 Oct 2019 09:11:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: bishop@php.net Date: Wed, 2 Oct 2019 12:11:00 -0400 Message-ID: To: Sara Golemon Cc: Nikita Popov , PHP internals Content-Type: multipart/alternative; boundary="000000000000a11f6f0593efb8c8" X-Envelope-From: Subject: Re: [PHP-DEV] Re: [VOTE] Reclassifying engine warnings From: bishop@php.net (Bishop Bettini) --000000000000a11f6f0593efb8c8 Content-Type: text/plain; charset="UTF-8" On Wed, Oct 2, 2019 at 11:45 AM Sara Golemon wrote: > On Wed, Oct 2, 2019 at 8:24 AM Nikita Popov wrote: > > > * The "Undefined array index" case. This one passed the vote with an > exact > > 2/3 majority, so I'm a bit uncomfortable making changes here. This is > also > > the only case where convincing usability concerns have been brought > > forward, primarily around the $array[$key]++ example. I'm not yet decided > > on what to do here and whether we should pursue additional library or > > language features first. > > > > > We raised margins to 2/3 to avoid having to feel bad about narrow > majorities. I say this as someone who was quite tempted to vote "Keep > Notice" which on retrospect would have changed the entire outcome based on > that one vote. > > If this had been a simple majority vote and it had pass by like.... > 52%-48%, then obviously that's not a mandate worth making potentially > catastrophic changes over, but this is 67% to 33%, it feels like you're > okay here. > I'd say it's ok, also: with 63 votes cast, I think we have a quorum and therefore representative opinion. (Per [1], this vote is second only in participation to typed properties 2.0, with 71 votes cast.) I personally abstained, seeing both sides of the argument. [1]:https://php-rfc-watch.beberlei.de/ --000000000000a11f6f0593efb8c8--