Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:107363 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 2453 invoked from network); 2 Oct 2019 18:04:34 -0000 Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12) by pb1.pair.com with SMTP; 2 Oct 2019 18:04:34 -0000 Received: from php-smtp3.php.net (localhost [127.0.0.1]) by php-smtp3.php.net (Postfix) with ESMTP id 160EC2C0530 for ; Wed, 2 Oct 2019 08:45:30 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp3.php.net (Postfix) with ESMTPS for ; Wed, 2 Oct 2019 08:45:29 -0700 (PDT) Received: by mail-qt1-f176.google.com with SMTP id d16so6351465qtq.8 for ; Wed, 02 Oct 2019 08:45:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XoGzdFUTwqE8m7iSfpi/aCI0BA2WIyvAn5R5WidMRuE=; b=hDWnxj4DaWL70G5GO9HreP85IfTbe7IshX4sBEFbk0k+ResuW1pBKRzOCqxnZtfofJ 62fQpC2WQyE1JvpVG+WH8h36hZUAKF/xybpRntaIQRLrbvsERV7T0CoUCpieNJK3SMol 7Y984pWCWmkB6+U868jR82+GyUFvePLRfMLpV7GmipE56qWq97cHrJQSENJMNWtatauO 8kyq5esr3BX4kO+28UUArcIvQprs3hd9J/hEJNZajLryRCRP5CG5QxehlymooAkRoBht qQphbAJCnemN6UVXqYJK66JAHhHLBFX1C3Yx8uP1pkiC5m9Ft/5NTSvXqesRxZrR8A2+ tqyg== X-Gm-Message-State: APjAAAVYSI++8IwCRXc4sAzzsDhmlddUJuMKThymOPJZqd8LNWdYz9bW vCfS9r+43Lu3hFSPIdOcWCZ6gBLfGAnYHmPxEnPVzA== X-Google-Smtp-Source: APXvYqy1/vLu5O/Q9I6ENDZcP/va3gJB8/R4k40uopHaT0xGVCTpQdfMqUn/X0J2hRPCaIbihT3gyW+13uWhPeTxGBw= X-Received: by 2002:aed:3e8d:: with SMTP id n13mr4846699qtf.116.1570031129067; Wed, 02 Oct 2019 08:45:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 2 Oct 2019 10:45:17 -0500 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000bc13650593ef5ba7" X-Envelope-From: Subject: Re: [PHP-DEV] Re: [VOTE] Reclassifying engine warnings From: pollita@php.net (Sara Golemon) --000000000000bc13650593ef5ba7 Content-Type: text/plain; charset="UTF-8" On Wed, Oct 2, 2019 at 8:24 AM Nikita Popov wrote: > * The "Undefined array index" case. This one passed the vote with an exact > 2/3 majority, so I'm a bit uncomfortable making changes here. This is also > the only case where convincing usability concerns have been brought > forward, primarily around the $array[$key]++ example. I'm not yet decided > on what to do here and whether we should pursue additional library or > language features first. > > We raised margins to 2/3 to avoid having to feel bad about narrow majorities. I say this as someone who was quite tempted to vote "Keep Notice" which on retrospect would have changed the entire outcome based on that one vote. If this had been a simple majority vote and it had pass by like.... 52%-48%, then obviously that's not a mandate worth making potentially catastrophic changes over, but this is 67% to 33%, it feels like you're okay here. -Sara --000000000000bc13650593ef5ba7--