Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107359
MIME-Version: 1.0
References: <CAG9XoMQp5wzs6msh_q33z1JEcMs2cNwWH+HmW4C9vYf+xLYeiA@mail.gmail.com>
 <CACXBjuimGBre6NwFmZ8cajscK=a0QB2LqpHy6arm6nEHd45RGw@mail.gmail.com>
 <CAG9XoMSbx1cRnka7zZyvkPmLYTocAEPP4+G_quz-Cxa-EsO4xA@mail.gmail.com>
 <CACXBjuj823HdUJofYgjkWuC8peWZ5Fm4=QkPg1C33CfYhdyYBw@mail.gmail.com> <CAG9XoMSFdaFcfV4sOss=5Uyg5H3yrhhywBRjkk-8JDZTe_gXMQ@mail.gmail.com>
In-Reply-To: <CAG9XoMSFdaFcfV4sOss=5Uyg5H3yrhhywBRjkk-8JDZTe_gXMQ@mail.gmail.com>
Date: Tue, 1 Oct 2019 13:26:10 -0700
Message-ID: <CACXBjug8qxtkkhY4eng+Heqw5y--uMe_SkK_6Uj1sRJL=JkdHg@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000748d60593df2ce2"
Subject: Re: [PHP-DEV] Error when POST / upload limits are exceeded
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--0000000000000748d60593df2ce2
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 1, 2019 at 8:25 AM Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> > Perhaps a more generic $_SERVER['PHP_REQUEST_STATUS'] or something along
> those lines where you'd put the error message from
> https://www.php.net/manual/en/features.file-upload.errors.php as well.
> And add new states for these exceeded limits that aren't caught there. It
> would be nice if you just needed a single check instead of having to look
> for multiple things.
>
> Those are per-file error codes, that belong in each $_FILES entry, while
> the errors I'm talking about affect the whole request, so I'm afraid you
> cannot put these errors in the same place, nor can you extend the existing
> error codes, as they do not have the same scope!
>

I know they are per-file errors. I wrote that code :)

But you could still have a global status that specifies whether an error
occurred or not. Then you can go look for which file it occurred on in the
$_FILES array. The idea is to have a single check that tells you if
everything was fine on the request.

-Rasmus

--0000000000000748d60593df2ce2--