Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107356
MIME-Version: 1.0
References: <CAG9XoMQp5wzs6msh_q33z1JEcMs2cNwWH+HmW4C9vYf+xLYeiA@mail.gmail.com>
 <CACXBjuimGBre6NwFmZ8cajscK=a0QB2LqpHy6arm6nEHd45RGw@mail.gmail.com>
In-Reply-To: <CACXBjuimGBre6NwFmZ8cajscK=a0QB2LqpHy6arm6nEHd45RGw@mail.gmail.com>
Date: Tue, 1 Oct 2019 15:32:39 +0200
Message-ID: <CAG9XoMSbx1cRnka7zZyvkPmLYTocAEPP4+G_quz-Cxa-EsO4xA@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009bfd6b0593d96320"
Subject: Re: [PHP-DEV] Error when POST / upload limits are exceeded
From: benjamin.morel@gmail.com (Benjamin Morel)

--0000000000009bfd6b0593d96320
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> We have https://www.php.net/manual/en/features.file-upload.errors.php but
in general this is not so easy to make more convenient because this runs
before your PHP code starts to run, so it is not like you can stick it in a
try/catch.

Hi Rasmus,

These errors are only relevant when you have something in $_FILES, which is
not always the case I'm afraid:

- when exceeding post_max_size, $_FILES is empty
- when exceeding max_file_uploads, you don't get entries in $_FILES past
the nth allowed file

I understand that because all of this happens before userland code is run,
indeed it's not possible to catch it.
I also understand that throwing a fatal error in this case would not be
welcome, as it does not give userland code a chance to inform the user
about the problem.

What about setting a $_SERVER value in this case? For example:

$_SERVER['CONFIG_LIMIT_EXCEEDED'] =3D 'post_max_size'

This, together with empty $_POST and $_FILES if any limit is exceeded
(including max_file_uploads), should be relatively sane behaviour IMO.

=E2=80=94 Benjamin

--0000000000009bfd6b0593d96320--