Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107340
Return-Path: <cmbecker69@gmx.de>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 29438 invoked from network); 27 Sep 2019 12:00:47 -0000
Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12)
  by pb1.pair.com with SMTP; 27 Sep 2019 12:00:47 -0000
Received: from php-smtp3.php.net (localhost [127.0.0.1])
	by php-smtp3.php.net (Postfix) with ESMTP id B94322D20E8
	for <internals@lists.php.net>; Fri, 27 Sep 2019 02:40:20 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS8560 212.227.0.0/16
X-Spam-Virus: No
Received: from mout.gmx.net (mout.gmx.net [212.227.15.19])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp3.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Fri, 27 Sep 2019 02:40:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1569577218;
	bh=7XgpBJtdxmcIENVQ/qKkwp3fOU03QWdb9x38BrfOS4g=;
	h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
	b=HoYp3o9SxO/FOUDC6AIs4bwyvyyrT7Pp6bmzKv3WssjxhN10xKAgmB/uINrnLZuFP
	 dZmZKG1SVpWxnJzRoysnXKk5GY0ARqftpGynyPfHVpdKhKTwyKfgBrMiNWzWCILzSM
	 gJhT/3oHjNHzGbHqf0cDciH2Frv2FHc6+7jOVXmo=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.2.144] ([84.179.236.50]) by mail.gmx.com (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1Ycr-1iBqva3fdD-003589; Fri, 27
 Sep 2019 11:40:17 +0200
To: =?UTF-8?Q?Alexandru_P=c4=83tr=c4=83nescu?= <drealecs@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>,
 "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAFp73XvOp_y7Gz1F4fdBHt1YiMibJ4zdbjrQ+LFxhHYW+-DoHg@mail.gmail.com>
 <44818c1e-07e4-19d5-2ef5-144ccb2b5c05@gmx.de>
 <CAFp73XvRoPfBFER3ezGXvhiEM3kTrNN1N-95zi8UC=ksExH_1A@mail.gmail.com>
 <CAAwdEzBufQ11iStNC9TjdF+1dCiaCNYqVB7hUikco7TVH2seyQ@mail.gmail.com>
 <CAF+90c_FpsxjDz9yBzSmZProx9XFxpZymcWXXtFdQEdHe7gEUQ@mail.gmail.com>
 <CAAwdEzCOGDBjrMDzZKQpwOYMSN93gq=f8G3ViDe2uO_fjEG=UQ@mail.gmail.com>
 <CAAwdEzAU5ft_PrKfgoAY3J79iTEy8Pn26oKByEtvju4Ur-suwQ@mail.gmail.com>
 <f263e8cd-6aec-ac6c-3c60-fadcbd3ebc9a@gmx.de>
 <CAAwdEzDB_RqMbqTJ9C8LZ_gug-wkFPbDhVzbCrfSWNS8J+D7bw@mail.gmail.com>
 <3628f06b-3c07-6a82-0aee-6a927c21a44d@gmx.de>
 <CAAwdEzBB+5VGEBS41nq_no8_BybhXXxvuVgyvT9wMBhF=bW7oQ@mail.gmail.com>
 <8cb2f498-6627-a412-ec65-dea8275c3199@gmx.de>
 <CAAwdEzCgg3z+PsupwPMyJ8Fnj4sHmKtqZ8mSEL_T62A6orMxSA@mail.gmail.com>
Message-ID: <9f7ae0f4-37a5-a6fe-3a84-00ffe88aef14@gmx.de>
Date: Fri, 27 Sep 2019 11:40:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAAwdEzCgg3z+PsupwPMyJ8Fnj4sHmKtqZ8mSEL_T62A6orMxSA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:FCdO2m1KUNFMh06Ew9WSQIeKeGHe87Ob/b2sFFWI6yavWiUSjE8
 /HLkdBAu11VXI+uqxyR1Pmzc1mQ5LK53s8Z6t0/ly8c2taLCuZlaAYezAd4oeWBpFsGNWdw
 YssJAoIb75EN6ZJrOPc4HQUw/TCdoLcPdG7yoVlLqWAdfP0a5g/ZWfr/lIKaEDau0ff0FNF
 4ZkR1RMbc3rgTvTwDDvMA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:67jJ02OuJOE=:cBaQkpTuxAD0P+Vg3ESJ9f
 YKBL4T0v3fH6dy5JPYYi1d02ocvNYx8J9ls/I6sRqXSkDRCQknGwBMK/4WrfRtSS1dyEaoPyJ
 Bin+R/rKog7kN2Nn1V77VoLYke3Sp2WWgshkdbbdT6yn4s7M6h9s2rL4eHr5sTDH5OnSDQ5Bj
 q6AT7TR7zrK44fWn/H4k0Jg5rHXlWAwX/wnSk3tbK5j5HN7GJ4Fc5Q4k9+jEiY6yu93jkmIrt
 9EOLALlu2Jz5CMghovv02crGlVt601A2aJrCwe/w4HLl1QzYzLbxVZ5ZQYNlWMbSlIvEjGyZV
 14wy+GTmY0GTfzdkG8Mz5d+iReromK+EILtyGCfMb91zZLzBEIgoB5rKqPFosnfT1KLphWdHX
 Ftt8qjNO5HF8gzgtOtO/FD2bE2RDChagFO+9JdCF7++GXGmlZ//mFgWg4pabW3FnJy5fXyigh
 ihc4IG/moGo2oi2xX7QYE//bTY4CAGL9V87oQMjPnbBHFwkQdPAS0vWLFMXLBvBwp3vYsSmU2
 W2itWvjzc3/FdlwnZ7wW+xCe2UVXTObQHtTGbGGftu4eK2CqDQaJ3vyAfxt+A8sqvOSD6OVgi
 3dKi8jfBNjLdjawmmzWL8PQmQ5wXLHYbBXns0tTe6lbg7K7rlln28zN/aM7GqLc8CnKc2hVdK
 rKkkGdJlOV45dDXgegeY1/YrvOwb4xZLoUByNU4z3qV6xSHAEZ/TlOAR7MIj+mzhHY79QqQBO
 CwLF8TX72uXCk/yh2OmSnnEGJqWLiHvJvraWp004yCe9Msalj8vZZUq2DWjLp24k46+LMqtqR
 G8TPtrRmTfyDLDh9dLf7c6p2ti7tg5jTPtUwICRdBOZMArwFQ3+fb7z8bQrIyWum+LQlnotQx
 8KxJ8sQUbP7TCrPAU1Wlz44eP4dKwJBQQv1903IelS6IVhq4fYv+kPpFPwhZz/a+akcwR2Len
 ie7rkG2MxcufAVXMCpCZcxDGN13xb3clOc3k1vAWPeUiek5v2MHzbhzw73Fmk5VRdmnPI53QK
 SfgAna7PoCCGQOvWic9yzRq8KJclZgb20rl5vM5A8SnQR2dFXA4hfgF6Tzq7ZVM9dDcOdJIr4
 ZqsYYlHXUeE0WU5kg2v6kySyorqu++WBVd56OihQWUAzLZgU+EsKS1wOs2Pe4FOxk8nxjxDpT
 Mvhfzbtb/XfbM8l21HCR0uKdIjUVk9eZrW4D1niTfOStyPNBbS+YNoqoY7ikSDQrbO2fFZO5b
 bDEwTnWlN/j+bU/hpgHh4WQDw8jEFwiEfuiQgWEyh+zXCVNDqLy+P2HyZHHs=
X-Envelope-From: <cmbecker69@gmx.de>
Subject: Re: [PHP-DEV] Re: Question about merged PR #937
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 27.09.2019 at 11:25, Alexandru P=C4=83tr=C4=83nescu wrote:

> The method you described looks great.
> Squashing with rebase interactive works fine, with choosing what commits=
 to
> keep and what commits to squash into the kept ones.
> This can be done by merger or author.
>
> Merging a pull request with squashing in github will set the author's
> commit to the person who merge it.
> The same things happens with *git merge --squash <branch>*
>
> If you agree, what would be the best way to propagate this information s=
o
> that everyone use this method, when squashing is needed?

I'm not sure if any commit actually removed the author information.
<https://github.com/php/php-src/commit/0adfa03397edcde8cba3bae2032b1f2ef26=
ea760>
certainly didn't, since this commit was not the actual merge, but rather
NEWS and UPGRADING information related to that PR.

So, where is the problem? :)

Regards,
Christoph