Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107317
MIME-Version: 1.0
References: <CAF+90c8EvfFPqjRJjJ3T-qTfLiWn7aZzCrGpk7R3yNFLT1qWjQ@mail.gmail.com>
 <CAF+90c8CvL3xvUpX1o2RH2Jjjj=fW5XbrLS5tkc6FdmS4cC+eQ@mail.gmail.com>
 <CAG9XoMRuvecyBQfB7fYEkO2=evdZ1wBHYVWioOcOMTJyObe2bQ@mail.gmail.com> <1544E25D-630F-4E02-BCF1-1A0DEF1EBD60@gmail.com>
In-Reply-To: <1544E25D-630F-4E02-BCF1-1A0DEF1EBD60@gmail.com>
Date: Tue, 24 Sep 2019 15:05:57 -0500
Message-ID: <CAESVnVr5xyZW25GFcKOcOhEHtCtOj6jbmzYnCzCcaApNO8m+jQ@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Benjamin Morel <benjamin.morel@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003bfa400593521151"
Subject: Re: [PHP-DEV] [RFC] Union Types v2
From: pollita@php.net (Sara Golemon)

--0000000000003bfa400593521151
Content-Type: text/plain; charset="UTF-8"

On Tue, Sep 24, 2019 at 12:24 PM Claude Pache <claude.pache@gmail.com>
wrote:
> The choice of supporting precisely the two literal values `null` and
`false`
> is not arbitrary: They are the two values that are the most often used as
> sentinel values (for indicating failure or absence). It is true that
`true` is
> also sometimes used as sentinel value (more rarely and not among the
> internal functions), but the same can be said of other literal values
> (one of your examples includes `0`).
>
While I personally think `false` makes sense as an allowed "type", I also
don't want to see the union types RFC get held up on such a tiny detail.

I would propose either of the following alternatives:
1/ Remove `false` from the proposal. It can always be added at a later
time, but not taken away.
2/ Make this detail a sub-vote.  I would suggest that this sub-vote should
also be subject to a 2/3 majority in order to pass.

-Sara

--0000000000003bfa400593521151--