Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:107263 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 17462 invoked from network); 20 Sep 2019 12:57:49 -0000 Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12) by pb1.pair.com with SMTP; 20 Sep 2019 12:57:49 -0000 Received: from php-smtp3.php.net (localhost [127.0.0.1]) by php-smtp3.php.net (Postfix) with ESMTP id BF1922D20C4 for ; Fri, 20 Sep 2019 03:35:41 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Virus: No Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp3.php.net (Postfix) with ESMTPS for ; Fri, 20 Sep 2019 03:35:41 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id a1so15038955ioc.6 for ; Fri, 20 Sep 2019 03:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fwbXSenqYCGXxM3Qk6Qu5Cf+W8jT/TY75KZOrdf3wfA=; b=Gic/iaZJbqFwoE/PIW41RciqQmaCd2dLCoaOjioghlhjx62PAZbdOvskaiyi0EFZkR XQBvzVYJu23KqmwV8ipvmW472b1/AYzv7Ml2zDYjjNGvL8V4LjGn1IPsJwtp+tAoPnDb QGe2So++BcA7swP1SYA1YjDyXcQq8z6b5o/gWV3tGFQ1bZrGd4w6Gpql7jxDSB3XERXY 95Fg4wnQCBgrIywAf/daywQt8mAlvb94Jg2JNUbw9I3mVxTcUuU8lay0ZNdEqbgm5iYl LjyTDDTK4oMWpJfkM4WyJ7obcvr5muDQLaTsH1kCtwmHchBB3ERIEb+n7F5bo/iLYZ3/ QZZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fwbXSenqYCGXxM3Qk6Qu5Cf+W8jT/TY75KZOrdf3wfA=; b=hQY8sx7w4wGkTNUBCPNq5DZFXYc802s5n3I+OtpYXJOxQJCwVYMP75zPCvBe3bOrfM sy9vilxnm+2wh94Y85gLMYjkaZS/RyYDU6VnLCq/j0t92+CEaI7LDUHXCyyywj38xx+b ygEznaP/hOfg+EhAapKcZL/TVXXnd6X2PC0dmQh22dRQC0/CgU/Y3V8ezwztpK0JfZZ0 K9g7t/M4rAjEpJJSj4ncTvzkXrjYcq+8EMa064KkBcPQu3Z7yX6JikSQo8oHVMT6ipsw ZmxloylwUjxmLozRP8+Yg1sTB+cU/3QUqKWyz0EFpyxNLr++LrWpZh8zZkicJVoyOVOc Ek6Q== X-Gm-Message-State: APjAAAUtllN069/3qFLQ2qWsIXLF67Q36lpjMb3Zer7tA5HNyt6U+EaP cTxZLBi1KNj+CjFPCi8CLULlcMY/Mrr8feqTUio= X-Google-Smtp-Source: APXvYqwQETOSvrIQe0bE1U4Ok5MqCWLBZ9IoJoRl4a1hWXYw8hyKXrUny9kOhx5QMukieJKuLMb9SOVhxRi+jS+c2f8= X-Received: by 2002:a02:7797:: with SMTP id g145mr18656868jac.60.1568975739723; Fri, 20 Sep 2019 03:35:39 -0700 (PDT) MIME-Version: 1.0 References: <44818c1e-07e4-19d5-2ef5-144ccb2b5c05@gmx.de> In-Reply-To: Date: Fri, 20 Sep 2019 13:35:12 +0300 Message-ID: To: "Christoph M. Becker" Cc: Nikita Popov , "guilhermeblanco@gmail.com" , PHP internals Content-Type: multipart/alternative; boundary="000000000000a0a5d20592f9a112" X-Envelope-From: Subject: Re: [PHP-DEV] Re: Question about merged PR #937 From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=) --000000000000a0a5d20592f9a112 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Christoph, Was this squash done during merging of a github pull request? On Fri, Sep 20, 2019 at 1:06 PM Christoph M. Becker wrote: > On 20.09.2019 at 11:22, Alexandru P=C4=83tr=C4=83nescu wrote: > > > I was quick to write an answer and forgot to search for a more detailed > > explanation online, being busy with some other work tasks. > > Github explains it here: > > https://help.github.com/en/articles/about-merge-methods-on-github > > > > Before enabling squashing commits, consider these disadvantages: > >> > >> - You lose information about when specific changes were originally > >> made and who authored the squashed commits. > > < > http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3D8326ef5519acb4dfcdcd3f= 059ee599d9e0faf174 > > > has just been squashed by me, and still has the proper author information= . > > -- > Christoph M. Becker > --000000000000a0a5d20592f9a112--