Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107262
To: =?UTF-8?Q?Alexandru_P=c4=83tr=c4=83nescu?= <drealecs@gmail.com>,
 Nikita Popov <nikita.ppv@gmail.com>
Cc: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAFp73XvOp_y7Gz1F4fdBHt1YiMibJ4zdbjrQ+LFxhHYW+-DoHg@mail.gmail.com>
 <44818c1e-07e4-19d5-2ef5-144ccb2b5c05@gmx.de>
 <CAFp73XvRoPfBFER3ezGXvhiEM3kTrNN1N-95zi8UC=ksExH_1A@mail.gmail.com>
 <CAAwdEzBufQ11iStNC9TjdF+1dCiaCNYqVB7hUikco7TVH2seyQ@mail.gmail.com>
 <CAF+90c_FpsxjDz9yBzSmZProx9XFxpZymcWXXtFdQEdHe7gEUQ@mail.gmail.com>
 <CAAwdEzCOGDBjrMDzZKQpwOYMSN93gq=f8G3ViDe2uO_fjEG=UQ@mail.gmail.com>
 <CAAwdEzAU5ft_PrKfgoAY3J79iTEy8Pn26oKByEtvju4Ur-suwQ@mail.gmail.com>
Message-ID: <f263e8cd-6aec-ac6c-3c60-fadcbd3ebc9a@gmx.de>
Date: Fri, 20 Sep 2019 12:06:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAAwdEzAU5ft_PrKfgoAY3J79iTEy8Pn26oKByEtvju4Ur-suwQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Question about merged PR #937
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 20.09.2019 at 11:22, Alexandru P=C4=83tr=C4=83nescu wrote:

> I was quick to write an answer and forgot to search for a more detailed
> explanation online, being busy with some other work tasks.
> Github explains it here:
> https://help.github.com/en/articles/about-merge-methods-on-github
>
> Before enabling squashing commits, consider these disadvantages:
>>
>>    - You lose information about when specific changes were originally
>>    made and who authored the squashed commits.

<http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3D8326ef5519acb4dfcdcd3f=
059ee599d9e0faf174>
has just been squashed by me, and still has the proper author information.

=2D-
Christoph M. Becker