Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107261
To: PHP internals <internals@lists.php.net>
Message-ID: <b8382e4b-4447-7a49-c026-2e79f7d7190f@gmx.de>
Date: Fri, 20 Sep 2019 12:02:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Unify mail related tests for *nix and Windows
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi all!

Currently our mail related tests (in ext/standard/tests/mail/ and maybe
other locations) are split for *nix and Windows (if there are even
Windows versions).  The basic difference is that the *nix variants set
the INI directive sendmail_path to just write the email to disk (some
variations exist), while the Windows tests use ext/imap.  The latter
tests are way more verbose, and such duplicated tests are generally a
pain point.

Therefore I suggest to unify these tests.  Basically, setting the
sendmail_path works for Windows as well; we only have to offer a binary
that writes the mail to disk (`tee` and non-binaries don't appear to
work).  A rudimentary implementation is trivial[1].

The then missing part would be to actually make the ini setting
portable, which might be done by introducing a new placeholder for PHPT
INI sections, similar to {TMP} and {PWD}.  The new placeholder would
likely have to accept a filename, so it could be something like
{MAIL:<filename>}.

Any ideas and suggestions for improvements, or potential caveats welcome!

[1] <https://gist.github.com/cmb69/40c8c3f40795d9032aec49d13e452fa5>

=2D-
Christoph M. Becker