Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107254
MIME-Version: 1.0
References: <CAEYWF=5S=u=sa_McyzfHocTQ50SQ02odz+h2UFoq0thdxbGarw@mail.gmail.com>
In-Reply-To: <CAEYWF=5S=u=sa_McyzfHocTQ50SQ02odz+h2UFoq0thdxbGarw@mail.gmail.com>
Date: Fri, 20 Sep 2019 09:52:15 +0200
Message-ID: <CAF+90c9TDqmpyrRS9FaL0gj4mcou-LQ+SwcgkcpGLTVppukuNA@mail.gmail.com>
To: Bishop Bettini <bishop.bettini@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000417e740592f75a0b"
Subject: Re: [PHP-DEV] Should changes to EXTENSIONS be with a direct master commit?
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000417e740592f75a0b
Content-Type: text/plain; charset="UTF-8"

On Fri, Sep 20, 2019 at 6:48 AM Bishop Bettini <bishop.bettini@gmail.com>
wrote:

> I've got the change below staged locally, but as you can see it's direct to
> master. Since that's an atypical workflow, and a first time for me, I
> wanted to check before I push.
>
> --- BEGIN git log ---
> commit f94d9dcc102ea5515974b3a721286a6b49840860 (HEAD -> master)
> Author: Bishop Bettini <bishop@php.net>
> Date:   Fri Sep 20 00:31:59 2019 -0400
>
>     [ci skip] Add phar + imap maintainer email
>
>     Looks like commit c09b13cb (Add Bishop Bettini as maintainer for
>     phar & imap, 2019-03-16) missed adding my email address.
>
> --- END git log ---
>
> Is this an appropriate case for a direct master commit?
>

Yes, this is fine. php-src has no strict review policy, use your own
judgement :) You'll likely want to get larger extension changes reviewed,
but especially if it's just about documentation changes, going through a PR
is not necessary.

Nikita

--000000000000417e740592f75a0b--