Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:107235 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 91036 invoked from network); 19 Sep 2019 19:42:45 -0000 Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12) by pb1.pair.com with SMTP; 19 Sep 2019 19:42:45 -0000 Received: from php-smtp3.php.net (localhost [127.0.0.1]) by php-smtp3.php.net (Postfix) with ESMTP id D4E092D1FC0 for ; Thu, 19 Sep 2019 10:20:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Virus: No Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp3.php.net (Postfix) with ESMTPS for ; Thu, 19 Sep 2019 10:20:26 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id m11so9692977ioo.0 for ; Thu, 19 Sep 2019 10:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oxOhEvXli1sL/T7YfAq0EMAOIXQ77Ov5VH5r9w09NGo=; b=UOUVfwWZwViXfAUaOga4QfKOQt9cdBpCUdtNRFBxCcs0a/8h6myWJ7AWT0fZH3R1Gp 5uLuG9sGMlFov346gL+RWaO5uAPfW7z2pZnkcRYMfg+6vQz8otaKd6spailtBWG9IphT V8bmFzjxa6QFNmbMLK1tbxN4AsYX1L0Wu1rc4gqRHHk9CzzqOlZW37i/QlDPA4kUgxZv lYqQ7xUxdYKaEwEeE6inwfxEhHzwwV8B/1OkzcbDj2NLEkq9uyj9F1fV3fdFo7a3l+zn 5SL++Km/NquFwuap+eppkadj0V4Eb0vTcTOLDAdB5iSZnA7+G4wL04Xf6FeVzJAMIO13 iq5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oxOhEvXli1sL/T7YfAq0EMAOIXQ77Ov5VH5r9w09NGo=; b=X6Dl6q2puw0UeYsjddeAm4mfib1pmRrR25Xdu7QFwFcAHeBDO7AHGyJi5RyH30z7bS VbLVcrCJ4TGZwJuxuef+vfHvxB8AFgIkzOZO39hE4g4S73xblab3Wh0mvMgmhyXlajHh NHptlEBRy1+2hToe7mGmDl39CusZ6dknNDv9FwIaH3590Zk38xIu8DwsLts2GtxxAHmr iokUmgEYAckNGDZ0eH0EurwUYXRjnO6XG5u1IdM8x8OX9CeWc1AQi/pFFsD5UQ+d/FhC 0LUpId9s6/aNqAMA2zug8Z1jT9XH3NjRv97fh0gwgXgLKPzHhgpyFIXowTfmJHxSKsz5 4Grg== X-Gm-Message-State: APjAAAWPXRQmnro1kxNP2vjPYF7Ae4kuLrEWfBEtxN67F2DJ3UVIQI2D KMB/OWnjP88UI/FVTs9GyzW3Xbvo9vcnsQGPiII= X-Google-Smtp-Source: APXvYqxtXNtSRovlcOc80Wk9yJn+kvcFMOMKHuecxLjSWuG74912idAFaMDq2JZFXkb1VDpTXFkLrD3cpu3dQV73Oqw= X-Received: by 2002:a6b:6101:: with SMTP id v1mr11336235iob.153.1568913625758; Thu, 19 Sep 2019 10:20:25 -0700 (PDT) MIME-Version: 1.0 References: <44818c1e-07e4-19d5-2ef5-144ccb2b5c05@gmx.de> In-Reply-To: <44818c1e-07e4-19d5-2ef5-144ccb2b5c05@gmx.de> Date: Thu, 19 Sep 2019 13:20:14 -0400 Message-ID: To: "Christoph M. Becker" Cc: PHP internals Content-Type: text/plain; charset="UTF-8" X-Envelope-From: Subject: Re: Question about merged PR #937 From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com") Thanks for the clarification Christoph! Somehow I couldn't see it when looking for the commit hash. Sorry for the disturbance in the list here. PS: I find it funny that even though I'm the original author of the code, I don't show as a contributor in any statistics. It'd be a shame to not be considered as a valid voter for "lack of recent contribution" to the language. Cheers, On Thu, Sep 19, 2019 at 12:58 PM Christoph M. Becker wrote: > > On 19.09.2019 at 17:01, guilhermeblanco@gmail.com wrote: > > One of my old PRs to PHP that was claimed to be merged disappeared > > from master. However, the upgrade note is still there in master and > > 7.4beta1. > > > > Here is the PR: https://github.com/php/php-src/pull/937 > > Here is the commit referencing it: > > https://github.com/php/php-src/commit/0adfa03397edcde8cba3bae2032b1f2ef26ea760 > > > > Please let me know if there's anything I can do to help. > > From what I can tell, everything is there. PR #911 has been merged as > , > and parts of that PR already with PR #928 as > . > > -- > Christoph M. Becker -- Guilherme Blanco SVP Technology at Statflo Inc. Mobile: +1 647 232 5599