Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107223
To: Claude Pache <claude.pache@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
References: <CAF+90c_Ds+UNZB4hAi1989SRafb=d1JkP2q4pdwkUUXfcHrLCw@mail.gmail.com>
 <CAF+90c90=zrRwcDSP_hGeYsw-Q=1M8JSYG1KWp-im1bOYuzJRQ@mail.gmail.com>
 <1BB4FA3E-23F6-45CB-9B8F-8DA3C497981D@gmail.com>
Message-ID: <a3ec09c5-f967-70e1-8beb-ba70bcd68d95@telia.com>
Date: Thu, 19 Sep 2019 00:53:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <1BB4FA3E-23F6-45CB-9B8F-8DA3C497981D@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [VOTE] Reclassifying engine warnings
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

Den 2019-09-18 kl. 21:44, skrev Claude Pache:

>> Le 18 sept. 2019 à 18:28, Nikita Popov <nikita.ppv@gmail.com> a écrit :
>>
>> I just realized that I missed one notice here, because it is generated from
>> a different location: "Constant %s already defined" (The define/const will
>> be ignored and the previous value used.)
>>
>> It would be great to have that as an exception for optimization reasons,
>> but as it's only a notice right now ... what do people think about
>> promoting it to a warning?
>>
>> Nikita
> Since attempting to define an already defined constant fails to perform the expected operation (i.e., defining the constant to *that* value), I think that a Warning is very reasonable.
>
> —Claude

I also think that a warning would be appropriate here.
Have stumbled on it myself, not having notices on.

r//Björn L