Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107213
MIME-Version: 1.0
References: <CAF+90c_Ds+UNZB4hAi1989SRafb=d1JkP2q4pdwkUUXfcHrLCw@mail.gmail.com>
 <CAF+90c90=zrRwcDSP_hGeYsw-Q=1M8JSYG1KWp-im1bOYuzJRQ@mail.gmail.com> <CAFp73Xtj4v9sfA5kYyC3QbqkSH1Mos7SAxRDuvcNw7F2tQ9wWg@mail.gmail.com>
In-Reply-To: <CAFp73Xtj4v9sfA5kYyC3QbqkSH1Mos7SAxRDuvcNw7F2tQ9wWg@mail.gmail.com>
Date: Wed, 18 Sep 2019 18:51:10 +0200
Message-ID: <CAF+90c9Ge9sFbFfyOtNb-DpVgX1Jtz8hc5L6GnqkiypCoorMuA@mail.gmail.com>
To: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d1c48f0592d6a55d"
Subject: Re: [PHP-DEV] Re: [VOTE] Reclassifying engine warnings
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000d1c48f0592d6a55d
Content-Type: text/plain; charset="UTF-8"

On Wed, Sep 18, 2019 at 6:32 PM guilhermeblanco@gmail.com <
guilhermeblanco@gmail.com> wrote:

> Nikita,
>
> I'd suggest to wait until the current vote ends and then open a new
> RFC to vote this one, otherwise it'll be disrupting.
>

Err, to be clear, I'm not suggesting to change the RFC under vote. We have
enough drama without that ;)

I certainly don't care about this enough to run it through a separate RFC
vote either. I'd like a simple consensus decision on a minor point. If
Chase & co tell me that "This is no problem for us, go ahead" or "This is
going to break all our code, leave it alone" that's good enough for me.

Context is that the current notice prevents constant propagation
optimizations. A warning won't help us either, but it would be the first
step towards making it an exception in the future, which *would* enable
those optimizations.

Regards,
Nikita


>
> On Wed, Sep 18, 2019 at 12:29 PM Nikita Popov <nikita.ppv@gmail.com>
> wrote:
> >
> > On Thu, Sep 12, 2019 at 2:17 PM Nikita Popov <nikita.ppv@gmail.com>
> wrote:
> >
> > > Hi internals,
> > >
> > > I've opened the vote on //wiki.php.net/rfc/engine_warnings.
> > >
> > > There are 4 votes, all of them independent. The first 3 are for
> specific
> > > cases that were controversial during the discussion, the last one is
> for
> > > the remainder of the proposal.
> > >
> > > Voting closes 2019-09-26.
> > >
> > > Regards,
> > > Nikita
> > >
> >
> > I just realized that I missed one notice here, because it is generated
> from
> > a different location: "Constant %s already defined" (The define/const
> will
> > be ignored and the previous value used.)
> >
> > It would be great to have that as an exception for optimization reasons,
> > but as it's only a notice right now ... what do people think about
> > promoting it to a warning?
> >
> > Nikita
>
>
>
> --
> Guilherme Blanco
> SVP Technology at Statflo Inc.
> Mobile: +1 647 232 5599
>

--000000000000d1c48f0592d6a55d--