Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107130
MIME-Version: 1.0
References: <CAEPJdu=DYZ8RTUtb-mDOGPdXGK4Z-h59rUq_A=wB=u6AaO7aDg@mail.gmail.com>
In-Reply-To: <CAEPJdu=DYZ8RTUtb-mDOGPdXGK4Z-h59rUq_A=wB=u6AaO7aDg@mail.gmail.com>
Date: Mon, 16 Sep 2019 02:39:46 +0200
Message-ID: <CAEPJdukijCzuiKRMfaMkpx72Er=Bj7K+MHqRyLytRoZmr3B3_w@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Cc: Thomas Weinert <thomas@weinert.info>
Content-Type: multipart/alternative; boundary="000000000000e7f20b0592a0d7ad"
Subject: Re: [RFC] DOM Living Standard API
From: kontakt@beberlei.de (Benjamin Eberlei)

--000000000000e7f20b0592a0d7ad
Content-Type: text/plain; charset="UTF-8"

On Fri, Mar 22, 2019 at 9:14 PM Benjamin Eberlei <kontakt@beberlei.de>
wrote:

> Hi Internals,
>
> Thomas and I are working on updating the ext/dom to add support for the
> current DOM Living Standard API as standardized here:
> https://dom.spec.whatwg.org/
>
> https://wiki.php.net/rfc/dom_living_standard_api
>
> This RFC is targeting 7.4 and contains three independent changes:
>
> - a set of new methods and interfaces that can be implemented BC as
> addition to the existing ext/dom.
> - a removal of a few "dead" classes that are exposed to userland, but
> neither documented nor containing implementation code.
> - a compatibility layer to switch the implementation between DOM Level 1-3
> and the Living Standard in places where BC is not possible.
>
> A pull request includes a nearly complete implementation of the new
> methods, but nothing of the cleanup/compatibility yet:
> https://github.com/beberlei/php-src/pull/1
>
> We are looking forward for your feedback.
>
> greetings
> Benjamin
>

Hi internals,

a few month have gone by and I came back to revisit this RFC and simplify
to get something shipped.

i have updated the RFC to only include the set of new methods and
interfaces that the DOM Living Standard has implemented.

https://wiki.php.net/rfc/dom_living_standard_api

I am asking about feedback especially on the section "Implementation
Details", that explains some key differences to "PHPify" the DOM Living
Standard API to PHP and ext/dom. Do you have any comments about the
reasonability of the choices?

Also the section on "Not adopting Nodes for now" is new and I need some
feedback on this issue: To keep the proposal slim with respect to changing
existing behavior, the improved behavior of the DOM Living Standard over
Level 1-2 tof automatically adopting nodes instead of throwing a WRONG
DOCUMENT DOMexception is not considered for now. Do you think this is a
reasonable approach to go forward with?

As for the implementation, it is now in this PR
https://github.com/php/php-src/pull/4709

Looking forward for further input.

Benjamin

List of Changes to RFC:

- The RFC has been updated to include a few more details about what each
new property or method does.
- The new behavior of the Living Standard of automatically adopting nodes
is skipped in implementation for now to keep the existing behavior of other
manipulation methods to throw WRONG document. Workaround is still to
importNode first. Adopting nodes can be implemented as improvement later,
because it has no backwards compatibility impact.
- I removed all sections on trying to achieve compatibility between old DOM
level 1-3 and the living standard, especially w.r.t. to DOMHtmlDocument
(uppercase nodeName, body property, ...). I think we can live with not 100%
compliant, ext/dom never was fully compliant. helpful would be a new
section in the docs that explains our existing differences to the spec to
users. Specifically the spec itself says that users should test existance
of features by checking for properties or methods.
- The cleanup of dead / unimplemented classes is not RFC worthy and can be
done without making the RFC more complex.

--000000000000e7f20b0592a0d7ad--