Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107057
To: PHP internals <internals@lists.php.net>
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com>
 <CAF+90c_KHYm1SLOKkZXM6xurYiDTX3=hbijpD8rT1OSUHSod_w@mail.gmail.com>
 <CEC35EF9-9956-44BE-8C8E-EE5FC3D5A7C7@gmail.com>
 <D5DDA318-E953-4AB8-873F-7CA7264722E2@koalephant.com>
 <E30D9A22-9842-4A67-ABA5-A339875FFE12@gmail.com>
 <CAG9XoMTG3OLbD0BfWv+ORUUsbMV2CaF0Ea4NLF1huHBr5JCmWQ@mail.gmail.com>
 <CALKiJKrftDt1ohJQLrgx+n57nf-TMVpUKYRVKWBkCa-ND1LVMg@mail.gmail.com>
 <CADyq6s+C07KABQcZ9x+vgH8pYdVcGZcx6m8Dg+E+LYn1RgOLoA@mail.gmail.com>
 <DED63BF6-96C5-475B-A263-C2E71961D8A6@gmail.com>
 <CALKiJKrMBXutarZLeZi4ctC0Xe6j-kW6VExXVujZad-uetxv4w@mail.gmail.com>
 <CAPKYkKyKr1gZ1P7YSaFn10g8Kk7qhTezWwKu75cAFwuwLNZBig@mail.gmail.com>
 <cb23e4fd-c47b-4ea4-2b0b-c69a2b1af8be@korulczyk.pl>
 <f5d6d324-9070-e33f-b4c2-a44029a6ef82@gmail.com>
 <3c843963-176d-85c8-bf89-cc944640a7fb@korulczyk.pl>
Message-ID: <0b4e8de1-5d3d-9646-49d0-6a2db41820d9@gmail.com>
Date: Fri, 13 Sep 2019 09:39:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <3c843963-176d-85c8-bf89-cc944640a7fb@korulczyk.pl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: rowan.collins@gmail.com (Rowan Tommins)

On 13/09/2019 09:01, Robert Korulczyk wrote:
> Actually you need only one additional line:
>
> $foo = [];
> foreach ( $something as $key1 ) {
>      foreach ( $somethingElse as $key2 ) {
>            $foo[$key1][$key2] ??= 0;
>            $foo[$key1][$key2]++;
>      }
> }


Why? If "assume $key2 exists as a key and is an integer" is so bad that 
PHP should halt my program, why should "assume $key1 exists and is an 
array" be perfectly OK?


> It does not look confusing. You have two lines, for two intents - start counting from zero and increment counter on every loop iteration.


There is no intent to start counting at zero; the counter will never be 
lower than 1. If we really wanted to express the intent, we would have 
to write something like this:


$foo[$key1] ??= [];
if ( ! isset($foo[$key1][$key2]) ) {
    $foo[$key1][$key2] = 1;
}
else {
    $foo[$key1][$key2]++;
}


> If one additional line is to much for making your code less ambiguous and more bug-free, then I won't even try to change your mind.


Please can you show me a bug that adding this line has avoided? I don't 
doubt that the same warning saves bugs in other scenarios, but in this 
scenario, the logic is unambiguous, and any additions are just to 
suppress unnecessary errors.

To reiterate, my motivation here is to discuss features that help write 
these scenarios with less boilerplate, and separate them from other 
scenarios where there's a real bug risk which should raise an error.


Regards,

-- 
Rowan Tommins (né Collins)
[IMSoP]