Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107049
To: Rowan Tommins <rowan.collins@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com>
 <CAF+90c_KHYm1SLOKkZXM6xurYiDTX3=hbijpD8rT1OSUHSod_w@mail.gmail.com>
 <CEC35EF9-9956-44BE-8C8E-EE5FC3D5A7C7@gmail.com>
 <D5DDA318-E953-4AB8-873F-7CA7264722E2@koalephant.com>
 <E30D9A22-9842-4A67-ABA5-A339875FFE12@gmail.com>
 <CAG9XoMTG3OLbD0BfWv+ORUUsbMV2CaF0Ea4NLF1huHBr5JCmWQ@mail.gmail.com>
 <CALKiJKrftDt1ohJQLrgx+n57nf-TMVpUKYRVKWBkCa-ND1LVMg@mail.gmail.com>
 <CADyq6s+C07KABQcZ9x+vgH8pYdVcGZcx6m8Dg+E+LYn1RgOLoA@mail.gmail.com>
 <DED63BF6-96C5-475B-A263-C2E71961D8A6@gmail.com>
 <CALKiJKrMBXutarZLeZi4ctC0Xe6j-kW6VExXVujZad-uetxv4w@mail.gmail.com>
 <CAPKYkKyKr1gZ1P7YSaFn10g8Kk7qhTezWwKu75cAFwuwLNZBig@mail.gmail.com>
 <cb23e4fd-c47b-4ea4-2b0b-c69a2b1af8be@korulczyk.pl>
 <f5d6d324-9070-e33f-b4c2-a44029a6ef82@gmail.com>
Message-ID: <3c843963-176d-85c8-bf89-cc944640a7fb@korulczyk.pl>
Date: Fri, 13 Sep 2019 10:01:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <f5d6d324-9070-e33f-b4c2-a44029a6ef82@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: robert@korulczyk.pl (Robert Korulczyk)

W dniu 12.09.2019 o 22:45, Rowan Tommins pisze:
> On 12/09/2019 15:43, Robert Korulczyk wrote:
>> One additional line will make your code much more obvious and easier to read and understand:
>>
>> $i ??= 0;
>> $i++;
> 
> 
> I don't find this code at all obvious:
> 
> foreach ( $something as $foo ) {
>     $i ??= 0;
>     $i++;
> }


That is because it does not make sense. You should initialize $i before loop, since it does not need a loop at all (and you probably don't need ??= here):

$i ??= 0;
foreach ( $something as $foo ) {
    $i++;
}

> Even using ??= the initialise-everything-before-use version looks like this:
> 
> $foo = [];
> foreach ( $something as $key1 ) {
>     foreach ( $somethingElse as $key2 ) {
>           $foo[$key1] ??= [];
>           $foo[$key1][$key2] ??= 0;
>           $foo[$key1][$key2]++;
>     }
> }

Actually you need only one additional line:

$foo = [];
foreach ( $something as $key1 ) {
    foreach ( $somethingElse as $key2 ) {
          $foo[$key1][$key2] ??= 0;
          $foo[$key1][$key2]++;
    }
}

> Again, the values are confusing: the end result will never contain an empty array at the first level, and will never contain a 0 at the second level.

It does not look confusing. You have two lines, for two intents - start counting from zero and increment counter on every loop iteration. If one
additional line is to much for making your code less ambiguous and more bug-free, then I won't even try to change your mind.


Regards,
Robert Korulczyk