Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106998
MIME-Version: 1.0
References: <076701d56978$86020910$92061b30$@php.net> <CADyq6sK4HektgfDpCCFR3=bumyPaf9vn=-WdvaboHybBQKd53g@mail.gmail.com>
 <078e01d5697c$5512bc10$ff383430$@php.net> <CAKws9z1EBSqCFy2wD3cEV49KDSJOd6tT04PrCkxG8+3Hb6WpTA@mail.gmail.com>
 <CAPKYkKw1EU3Qp6W7b19r4kMKPD1HntH+7NQSxSiDNcLXqPERMA@mail.gmail.com>
 <CAKuGYLRWF9jnS-Zs+uRFNN1pgRSvHFpW-FChgNq9Rk282AFFGA@mail.gmail.com>
 <CAPKYkKxUyeWWZY5OyDLtAYiDUYLkwyMjuc_Wq2Y++3C9CP6G1w@mail.gmail.com>
 <CANS-=pc7Av0+jSKNebb-iae+BpTt6_72kRSHSowb-hon4rxUgQ@mail.gmail.com> <31BD63BC-ACE0-4478-B241-E698D2D6F59C@newclarity.net>
In-Reply-To: <31BD63BC-ACE0-4478-B241-E698D2D6F59C@newclarity.net>
Date: Thu, 12 Sep 2019 20:09:59 +0200
Message-ID: <CANS-=pexJhtBS=me8RDvg0+BjXWVqmONU4CDVyrGgcsia40YGA@mail.gmail.com>
To: Mike Schinkel <mike@newclarity.net>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002bdd7705925f0d03"
Subject: Re: [PHP-DEV] Changing fundamental language behaviors
From: kjarli@gmail.com (Lynn)

--0000000000002bdd7705925f0d03
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 12, 2019 at 7:59 PM Mike Schinkel <mike@newclarity.net> wrote:

>
>
> Just a few weeks ago I was refactoring some particularly horrible code
> developed by previously employed developers =E2=80=94 a code based that h=
as a 1400
> line function and many other functions 100s of lines long, and I added so=
me
> initialization for variable and array elements prior to their use.
>
> Unfortunately my changes broke the code because the original developer
> using isset($var) as branching criteria.  After finding this bug, I
> realized that this code base uses that technique frequently.  I am know
> from lots of experience that this is a common technical among WordPress
> plugins.
>
>
The bug is not that you initialized the variable, it's that you initialized
it with a different value: https://3v4l.org/8mB8B
```
var_dump(isset($a));
$a =3D null;
var_dump(isset($a));

// gives
bool(false)
bool(false)
```

Whenever one of these errors will occur, you can initialize either the
array key or variable with null and it will work again without changing
behavior. If anything, Wordpress shouldn't be an argument to not improve
PHP, though I think it's important to consider the impact of a change,
including for the Wordpress community. However, I think most people agree
that the quality of Wordpress code and Plugins is highly debatable. I don't
like the idea of not being able to progress because Wordpress users won't
upgrade PHP.

Regards,
Lynn van der Berg

--0000000000002bdd7705925f0d03--