Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106839
User-Agent: Cyrus-JMAP/3.1.7-154-gfa7592a-fmstable-20190829v1
Mime-Version: 1.0
Message-ID: <fd46897e-4400-4566-a945-4d47b7d95766@www.fastmail.com>
In-Reply-To: 
 <CAH0Uv3HpPksJDmqHe1nXo7fmZsyu7qMRgQeXz6aLdn37kDSZgQ@mail.gmail.com>
References: <C228D1E3-C20A-42B8-8006-01E34FFFB5A6@cschneid.com>
 <CA+kxMuRBRNkPKK+rf-vMFOcOEr3a4a9+VJ3hRrtPF_4asbmg4g@mail.gmail.com>
 <F982CE0F-B1E1-4E66-A8A0-AAFA77FE0F12@cschneid.com>
 <CAH0Uv3HpPksJDmqHe1nXo7fmZsyu7qMRgQeXz6aLdn37kDSZgQ@mail.gmail.com>
Date: Tue, 03 Sep 2019 19:09:11 -0500
To: "Steffen via internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] Mixed mode methods
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Sep 2, 2019, at 1:03 PM, Andreas Hennings wrote:


> The value of parameter-based polymorphism is for cases where the
> calling code wants to handle all parameter types in one call, whereas
> the callee has different implementations for different parameter
> types.
> 
> This is not the case here: The calling code does always know whether a
> call should be static or not, so it can choose the applicable method
> name.

This is what I don't get.  How can it not?

If a method is static-safe, and you want to call it from both static and object contexts... Make it a static method and call it statically from both contexts.  That's fine.  If it's not safe to call from a static context (because it reads $this), you couldn't call it statically anyway.

If the method has 2 different logic paths, depending on if it's a static or object context, then it should be two different methods.  Folding them into one just pushes more conditionals down deeper into the code where the cyclomatic complexity impact is greater.  That's not a win.

--Larry Garfield