Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106826
Date: Sat, 31 Aug 2019 05:23:06 +0200 (CEST)
Reply-To: Thomas Bley <mails@thomasbley.de>
To: Matthew Brown <matthewmatthew@gmail.com>
Cc: Internals <internals@lists.php.net>
Message-ID: <1184971592.96503.1567221786282@email.ionos.de>
In-Reply-To: <C5B47114-56C3-43AA-BA02-4FA21528C0C5@gmail.com>
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com>
 <CAKuGYLQC2z+GmOgbqxFWbAGS6B2z=mXTp72c6Be53ju4D6pNRw@mail.gmail.com>
 <B6913F25-2859-4BA5-906F-8F6B245BA8E8@gmail.com>
 <CAKuGYLRBEd6_hD=LwV1y+8NjA3S0HxnNwEFMYDUDQ9D2JR6s8A@mail.gmail.com>
 <702735435.20836.1567008353931@email.ionos.de>
 <C5B47114-56C3-43AA-BA02-4FA21528C0C5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Medium
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: mails@thomasbley.de (Thomas Bley)

That's a good point, maybe a compromise is this:

<?php // php latest
<?php7 // old behaviour

That way new users can always use <?php, maintainers for old code bases can quickly patch the code with <?php7 to force the old way of engine warnings.

Regards
Thomas

> Matthew Brown <matthewmatthew@gmail.com> hat am 28. August 2019 um 18:21 geschrieben:
> 
> 
> FWIW: all the runtime notices in our codebase come from internally-created code.
> 
> Requiring declare(strict_variables=1) to get this (better) behaviour punishes future users of PHP for our past mistakes.
> > On Aug 28, 2019, at 12:05 PM, Thomas Bley <mails@thomasbley.de> wrote:
> > 
> > Normally every code base has old and new code, some is actively maintained, some is probably third-party maintained, some is unmaintained. Business normally not calculates costs for upgrading, securing, GDPRing old code, so bigger changes always leave some people behind.
> > I would prefer to write new code with sth like declare(strict_variables=1); or declare(SomeNamespace\Foo:strict_variables=1); That way, people can write new code in a better way, include new libraries and upgrade old code piece by piece without any big pressure.
> > 
> > Regards
> > Thomas
> > > Matthew Brown <matthewmatthew@gmail.com> hat am 28. August 2019 um 17:32 geschrieben:
> > > 
> > > 
> > > It's essentially tech debt, and the language has allowed its users to
> > > accrue a ton of it.
> > > 
> > > The longer that's allowed (deprecations/warnings prolong the issue in my
> > > opinion) the harder it will be to fix the issues.
> > > > On Wed, 28 Aug 2019 at 10:56, Rowan Collins <rowan.collins@gmail.com> wrote:
> > > > On 28 August 2019 15:22:22 BST, Matthew Brown <matthewmatthew@gmail.com>
> > > > wrote:
> > > > > Looking at our notice logs, I estimate (fairly roughly) that it would
> > > > > require about a week's worth of my time to fix these issues
> > > > I honestly thought you were posting that as an argument against. A week of
> > > > resource (plus the accompanying QA impact etc) is a significant investment
> > > > for many organisations. That's why it has the potential to delay adoption
> > > > of a new version, and why a long lead-in via deprecation or opt-in is
> > > > necessary.
> > > > Regards,
> > > > --
> > > > Rowan Collins
> > > > [IMSoP]
> > > > --
> > > > PHP Internals - PHP Runtime Development Mailing List
> > > > To unsubscribe, visit: http://www.php.net/unsub.php
> 
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php