Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:106764 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 68066 invoked from network); 28 Aug 2019 21:53:51 -0000 Received: from unknown (HELO mail-lj1-f175.google.com) (209.85.208.175) by pb1.pair.com with SMTP; 28 Aug 2019 21:53:51 -0000 Received: by mail-lj1-f175.google.com with SMTP id l14so677711lje.2 for ; Wed, 28 Aug 2019 12:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=td95xXxGjr8hXzeAEqTQNzYam3LWszB785jcr2h9HaU=; b=HHkdLDgFb2i8fxQ0PrRhNFciQ1b2SBF7pkxIkyugZNRKEAD6e9wh8cM9nfpS69l4GG WB/CwZ1E865ka4FI4AsFVC/kf1BUlqmSjMfI13oswdM2uQkv1T83EQ2ZhLOD0ySCuxBW 92W66d/paXUl1+j5126HSRgOOOyhWB4Z7tzakQChvDU1zN643aSfRDvUxpgwGonQSxIa TIAKSROTw9jh8cAHr1grou2yGlI/ozxXAeoFAe0gC6nV6E907afwG9NKna1lWPxpyC1R m5nYDUuW80z7jRcH5YX1HyTus6DZl/7BVNgORnF9TgH07rfSSs7QZo6QGfcnqhtqsUii OMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=td95xXxGjr8hXzeAEqTQNzYam3LWszB785jcr2h9HaU=; b=Mw9mYVbLc0L1xYYYAAzIeKUD+dyOPZxWjg9doaCwoypS6DuFain2VxH47yOy23aKm/ UT5r+5SMDL56Auv5c1y6K3xYtXcT0oO51xkWoRViXxweP8hyqEgZCosRMHXThJbTPGPO oM84q3mMvuf1Xq90k042VvT4a6um11LV9TZY/IXaERLfJ5X5na6DWH6eQhZhwGCHImxy kdTkShNUKSEi9ZoUTpHqH9H1zhpHbotix9Y0D+o1dRm7Luba+tlhrFUzl3uy48eHfjCF XQvVNVnDghtc+rknM5HxJypBmYTc+7iv7oxi31/TEtqv2Wg4GR6FbYMiMAwdZaxoJFIw KX5g== X-Gm-Message-State: APjAAAWnRySfiUlBYB+cWw7o+EF36mV6hxcYK/iNsLi/wr33g3/meLCh gG8C2aI1U3LvSvSJYowDai2vXTr7Bim0nBFAi62e0AwY X-Google-Smtp-Source: APXvYqzYKDga1KA4dMIEoYXHQiBB3BhUdJIAdOMyL9h0xa2FNxYQuM0JKTwfR6H8ooeoY4WfFi2ZhErHzSbVzll36Zw= X-Received: by 2002:a2e:969a:: with SMTP id q26mr2859702lji.227.1567020362998; Wed, 28 Aug 2019 12:26:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 28 Aug 2019 21:25:46 +0200 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="00000000000017a8610591325c82" Subject: Re: [RFC] Reclassifying engine warnings From: nikita.ppv@gmail.com (Nikita Popov) --00000000000017a8610591325c82 Content-Type: text/plain; charset="UTF-8" On Wed, Aug 28, 2019 at 11:33 AM Nikita Popov wrote: > Hi internals, > > I think it's time to take a look at our existing warnings & notices in the > engine, and think about whether their current classification is still > appropriate. Error conditions like "undefined variable" only generating a > notice is really quite mind-boggling. > > I've prepared an RFC with some suggested classifications, though there's > room for bikeshedding here... > > https://wiki.php.net/rfc/engine_warnings > > Regards, > Nikita > It seems quite clear to me that the question of the "undefined variable" error is contentious. As such, I have decided to split it off into a separate section in the proposal, that will be voted separately from the rest. I will offer the choice of throwing an Error exception (as originally proposed), throwing a warning or keeping the existing notice. Reading this discussion has been disappointing and somewhat disillusioning. I can understand and appreciate the concern for legacy code. But seeing the use of undefined variables espoused as a legitimate programming style, that just makes me sad. Regards, Nikita --00000000000017a8610591325c82--