Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106747
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
In-Reply-To: <702735435.20836.1567008353931@email.ionos.de>
Date: Wed, 28 Aug 2019 12:21:44 -0400
Cc: Rowan Collins <rowan.collins@gmail.com>,
 Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C5B47114-56C3-43AA-BA02-4FA21528C0C5@gmail.com>
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com> <CAKuGYLQC2z+GmOgbqxFWbAGS6B2z=mXTp72c6Be53ju4D6pNRw@mail.gmail.com> <B6913F25-2859-4BA5-906F-8F6B245BA8E8@gmail.com> <CAKuGYLRBEd6_hD=LwV1y+8NjA3S0HxnNwEFMYDUDQ9D2JR6s8A@mail.gmail.com> <702735435.20836.1567008353931@email.ionos.de>
To: Thomas Bley <mails@thomasbley.de>
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: matthewmatthew@gmail.com (Matthew Brown)

FWIW: all the runtime notices in our codebase come from internally-created c=
ode.

Requiring declare(strict_variables=3D1) to get this (better) behaviour punis=
hes future users of PHP for our past mistakes.

> On Aug 28, 2019, at 12:05 PM, Thomas Bley <mails@thomasbley.de> wrote:
>=20
> Normally every code base has old and new code, some is actively maintained=
, some is probably third-party maintained, some is unmaintained. Business no=
rmally not calculates costs for upgrading, securing, GDPRing old code, so bi=
gger changes always leave some people behind.
> I would prefer to write new code with sth like declare(strict_variables=3D=
1); or declare(SomeNamespace\Foo:strict_variables=3D1); That way, people can=
 write new code in a better way, include new libraries and upgrade old code p=
iece by piece without any big pressure.
>=20
> Regards
> Thomas
>=20
>> Matthew Brown <matthewmatthew@gmail.com> hat am 28. August 2019 um 17:32 g=
eschrieben:
>>=20
>>=20
>> It's essentially tech debt, and the language has allowed its users to
>> accrue a ton of it.
>>=20
>> The longer that's allowed (deprecations/warnings prolong the issue in my
>> opinion) the harder it will be to fix the issues.
>>=20
>>> On Wed, 28 Aug 2019 at 10:56, Rowan Collins <rowan.collins@gmail.com> wr=
ote:
>>> On 28 August 2019 15:22:22 BST, Matthew Brown <matthewmatthew@gmail.com>=

>>> wrote:
>>>> Looking at our notice logs, I estimate (fairly roughly) that it would
>>>> require about a week's worth of my time to fix these issues
>>> I honestly thought you were posting that as an argument against. A week o=
f
>>> resource (plus the accompanying QA impact etc) is a significant investme=
nt
>>> for many organisations. That's why it has the potential to delay adoptio=
n
>>> of a new version, and why a long lead-in via deprecation or opt-in is
>>> necessary.
>>> Regards,
>>> --
>>> Rowan Collins
>>> [IMSoP]
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>=20