Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106736
MIME-Version: 1.0
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com>
 <CAJHtznyadHb5_RgjddnPiyeWXtLQyp2CDK=ix=BiEd+DEUHqLg@mail.gmail.com>
 <CAF+90c_94zAj-7XW+=YtZ2VsZEshd4DvNY8_17PyiBXvYR1gdw@mail.gmail.com>
 <CAJHtznw5wOTMA-BUO6hOARxSie75+PwccSocVapHi4k02Z+x0A@mail.gmail.com>
 <CAPKYkKzc37d52ZjHy0ht6Oc_HgoBq4+DandNW1Hk-+x5NnUS7Q@mail.gmail.com>
 <CAPKYkKwhUmq40yGta3+ERfcDOOrkPi5Db6-i7pPMRmV4CrQRTQ@mail.gmail.com>
 <7ddbae5c-7451-4094-8b32-19676128054b@thelounge.net> <CAPKYkKyYvqW9Hm-nae0CXJ98XxRzt7XRpe_+FzeqiJME3K4jug@mail.gmail.com>
 <CAPKYkKw5vxgeM+vq_z9YhNYEMuPodCjfGNv6BRFS+bg0BG-Q0w@mail.gmail.com>
 <CAOkcCt_xsP1AOwB0-nuY4_qwxSc3h8mns_Yax9UnrLzFCN-m+g@mail.gmail.com>
 <CAPKYkKxAkowF_H9gDZg2pDVdUyftJz0b2LAE08jW8jjA6Nq-uw@mail.gmail.com> <CADyq6sJd6=2UEXXrad2heYw4Mp876rSQ9ZcKeuXOKEWO8F2saA@mail.gmail.com>
In-Reply-To: <CADyq6sJd6=2UEXXrad2heYw4Mp876rSQ9ZcKeuXOKEWO8F2saA@mail.gmail.com>
Date: Wed, 28 Aug 2019 10:54:32 -0400
Message-ID: <CAPKYkKw7Q7A4Z5TkgNX-=LPZZy7_orCRUsULBA7j=wZgKU-VuQ@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Gert <gertp93@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d2926205912e911c"
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: chasepeeler@gmail.com (Chase Peeler)

--000000000000d2926205912e911c
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 28, 2019 at 10:39 AM Marco Pivetta <ocramius@gmail.com> wrote:

> On Wed, Aug 28, 2019 at 4:27 PM Chase Peeler <chasepeeler@gmail.com>
> wrote:
>
>> On Wed, Aug 28, 2019 at 10:20 AM Gert <gertp93@gmail.com> wrote:
>> Notices include a lot more than just undeclared variables. Turning them on
>> in our environment would pretty much make the logs unusable for any on the
>> spot checking for issues. They would only be useful if we were trying to
>> parse out specific errors, and, they would be HUGE. Each web server
>> generates about 5-10 megs of logs in a day. Our CLI servers (which runs
>> beanstalkd jobs) generates about 80-100 megs of logs in a day. That's
>> without notices turned on.
>
>
> I worked with clients with much more log overhead happening: the solution
> is working to fix these issues, and not ignoring more of them.
>
> You going to come and fix the issues? It's an internal application and
most of those messages are coming from legacy areas of the code which are
mainly "it works, so leave it alone" things. Instead of going back and
spending time trying to fix those boondoggles, we invest the time of our
developers (there are 2 others besides myself) into building new features
that help our business grow. Time permitting, we try and update some of the
legacy areas, but, we usually find it's a better investment to just rebuild
them at that point.

Bottom line is that we live with the not-so-good stuff so that we can focus
on adding new great stuff. The not-so-good stuff isn't holding us back, and
trying to fix things like undeclared variables would have absolutely ZERO
positive effect on our business, which uses this application every day. If
I went to our executive team and said "Can we delay that new scheduling
system that will really help our business so I can go back and update code
to get rid of these undeclared variable notices?" I'd get laughed at!

Like I've said before - can we please stop pretending we understand
everyone else's situation? Maybe my situation is unique. My gut tells me it
might be unique among people on this list, but, that it's actually pretty
common among the myriad of developers out there which never get involved in
these discussions.


> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>


-- 
Chase Peeler
chasepeeler@gmail.com

--000000000000d2926205912e911c--