Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:106730 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 84332 invoked from network); 28 Aug 2019 16:50:24 -0000 Received: from unknown (HELO mail-yb1-f172.google.com) (209.85.219.172) by pb1.pair.com with SMTP; 28 Aug 2019 16:50:24 -0000 Received: by mail-yb1-f172.google.com with SMTP id s142so16339ybc.6 for ; Wed, 28 Aug 2019 07:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9jbL3GwtvwguYWmiaY2SoL+jxje7rfSRYxNgql1TSIs=; b=phn3gxGQnvUj7pN19cLu+21Iik9z4l0jVUYxdY9ZgcHm6s5kBIgnz1uk9n0Pn78myJ YFxSCcws0S1mMjky9mqBZHf6MBeKbfaDdkdbyt6jswwEvYU7K0IwKbgKgHN+sItFG2Zv gGBdOz00NsHgwj9DglkeqvTukN4OlO7r7+K8mEjnwFkDHB2kZmbcslmBUt87OzQK6LWh iMPbEvwltHKk3mx158v/sSKvT87RE5wwZgPXik6U/ZI+bMSTzbpD/WYhyqkyiloDXzsl cVH0huYK/aaymUUEsw2EVPpKO3VvksJ27BkaCQanko5gANvXbfRbpIRUcDP4j6g8aGNF V0YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9jbL3GwtvwguYWmiaY2SoL+jxje7rfSRYxNgql1TSIs=; b=s3j+085unUhMEBh6olibY9gbPB3IfjcrallhA8619zCN+PZKdf5FPT8L2OEBxPBBTw qqDu7cFWdq24rpsvmrVmHkhpZwKZ/yLnMGLYU74EQYQZvNPqvQVJOSGZW4JUAwgVHaWL CmVnh25Im5o8fAnQAiYtMAQ8uxlS/ZDt7CtyFFkUgXNR4lpXtsmyT9Xj+K1qiNO7yzT2 1eiYMMku02BlV+K4JqAULOcHCV2p/u66/f8reIs0w8/vC22D2XeuWObJ2fGDH/2mg3jI PXRnGC+IkbZmVkkg/r/1CJdYSAtySaqjbeVvzUauJlAMuUYXfrhBlTBOycJhPZ9piQxN YVBA== X-Gm-Message-State: APjAAAXMxHxHw2ZUi8kjfUgeUu6zNDIIJsUdYrSJm6pmrexaDjyfnWMV 8G3kZUBKSiLnN9s7jd5ZZ4lGxlxX+tWjDP+BZK7W7z/K X-Google-Smtp-Source: APXvYqzZ5TIYqhj6hXa1Srz6T0+0OTUR/3GzGfMMlBf/Tn2uTQpSNi9bupjqn9QQ/xWIb5R9DGdQhAhPP3LufcS2CCI= X-Received: by 2002:a25:ad45:: with SMTP id l5mr3166558ybe.134.1567002153522; Wed, 28 Aug 2019 07:22:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 28 Aug 2019 10:22:22 -0400 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000b91f0005912e1e7f" Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings From: matthewmatthew@gmail.com (Matthew Brown) --000000000000b91f0005912e1e7f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Looking at our notice logs, I estimate (fairly roughly) that it would require about a week's worth of my time to fix these issues in vimeo.com=E2= =80=99s 700K LOC codebase (the undefined variables are confined to our views). IMO it's akin to taking the training wheels off the language =E2=80=93 I th= ink the PHP ecosystem is mature enough to deal with the change. On Wed, 28 Aug 2019 at 05:34, Nikita Popov wrote: > Hi internals, > > I think it's time to take a look at our existing warnings & notices in th= e > engine, and think about whether their current classification is still > appropriate. Error conditions like "undefined variable" only generating a > notice is really quite mind-boggling. > > I've prepared an RFC with some suggested classifications, though there's > room for bikeshedding here... > > https://wiki.php.net/rfc/engine_warnings > > Regards, > Nikita > --000000000000b91f0005912e1e7f--