Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106724
MIME-Version: 1.0
References: <CAF+90c9Kc6m_bv=aJxbD3-RmnNXXLqv6mPjHp7U7qxX_ck27qw@mail.gmail.com>
 <CAJHtznyadHb5_RgjddnPiyeWXtLQyp2CDK=ix=BiEd+DEUHqLg@mail.gmail.com>
 <CAF+90c_94zAj-7XW+=YtZ2VsZEshd4DvNY8_17PyiBXvYR1gdw@mail.gmail.com>
 <CANS-=pepNMEj0O_zp4j7eMZAFi+BN=h0fsYjqQTS45pQaAuF0g@mail.gmail.com> <CAF+90c8ZN_RksLKZNVqdCo6+GsAQDpq8LxXUNtqAUr3q9Z9SPw@mail.gmail.com>
In-Reply-To: <CAF+90c8ZN_RksLKZNVqdCo6+GsAQDpq8LxXUNtqAUr3q9Z9SPw@mail.gmail.com>
Date: Wed, 28 Aug 2019 15:29:30 +0200
Message-ID: <CANS-=pcjhaWU=PAanmbK-47BuKG7jKhoDST6ZDt61_Q7Qpprtw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Zeev Suraski <zeev@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008cf0db05912d62a4"
Subject: Re: [PHP-DEV] [RFC] Reclassifying engine warnings
From: kjarli@gmail.com (Lynn)

--0000000000008cf0db05912d62a4
Content-Type: text/plain; charset="UTF-8"

However, I feel pretty strongly that converting any of these to
> deprecations is not a good idea. While there's certainly different views on
> this, I've seen it often enough deprecation warning are considered an even
> lower error level than notices (imagine my surprise when PEAR stopped
> working completely in PHP 8 because nobody ever saw the hundreds of
> suppressed deprecations). We could throw a deprecation in addition, but I
> think this will make the development experience really suck for anyone who
> is not actively working on a migration right now (imagine seeing lots of
> warnings/notices during development twice).
>

You got a very valid point here. As long as there is a clear migration
path, albeit with user-land tools, I'll take it.



> I think it would be better to register an error handler that matches the
> cases that will throw and can then log those. I'd be happy to provide an
> implementation if you think this would be useful for your use-case. Also
> has the nice advantage that you can start using it right now and don't have
> to wait until you upgrade to a release that has deprecations.
>

It would be great to have a package that reports all these cases, though we
could try to craft something ourselves if this RFC is approved. Perhaps
frameworks providing error handlers can add specific logging for these
scenarios as well, saves you from putting more effort in this than required.

Regards,
Lynn van der Berg

--0000000000008cf0db05912d62a4--